Update "isApplication" label default value to true

When the app.starlingx.io/component label was added to pods it was decided that it would be controlled by a values.yaml key labels:isApplication and its default value was set to "false" [1] and [2]. This should be changed to "true" since all pods created by the stx-openstack charts are related to the stx-openstack app. Additionally, according to LP #2052539 this new label was mixing memory usage metrics and wrongly triggering platform alarms for "Memory threshold exceeded". [1] https://review.opendev.org/c/starlingx/openstack-armada-app/+/903918 [2] https://review.opendev.org/c/starlingx/openstack-armada-app/+/904128 TEST PLAN: PASS - Build openstack-helm package PASS - Build openstack-helm-infra package PASS - Build stx-openstack application tarball PASS - Upload/Apply stx-openstack application (AIO-DX) PASS - No alarms triggered after application is applied Closes-Bug: 2052539 Change-Id: I6e3e99b48c65d6c1730eca2f85b9d700dd6b1ef9 Signed-off-by: Thales Elero Cervi <thaleselero.cervi@windriver.com>
2024-02-09 15:04:32 -03:00 · 2024-02-09 15:04:32 -03:00 · 4cd7a5d544
commit 4cd7a5d544
parent ef24b3d8da
8 changed files with 29 additions and 29 deletions
--- a/openstack-helm-infra/debian/deb_folder/patches/0017-Add-app.starlingx.io-component-label-to-pods.patch
+++ b/openstack-helm-infra/debian/deb_folder/patches/0017-Add-app.starlingx.io-component-label-to-pods.patch
@ -2,9 +2,6 @@ From de4f807376a58fa6b04163bc04cdbdad14777540 Mon Sep 17 00:00:00 2001
 From: dbarbosa <david.barbosabastos@windriver.com>
 Date: Wed, 20 Dec 2023 06:51:59 -0300
 Subject: [PATCH] Add app.starlingx.io/component label to pods
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit

 Add the label app.starlingx.io/component to the pods and allow the
 value to be updated via "system helm-override-update". This change
@ -16,6 +13,10 @@ the variable "label.isApplication" in the values.yaml file is
 different from true or false, the label will not change.

 By default, all pods start with the value platform.
+
+Signed-off-by: David Bastos <david.barbosabastos@windriver.com>
+[ Updated "isApplication" labels values to "true" ]
+Signed-off-by: Thales Elero Cervi <thaleselero.cervi@windriver.com>
 ---
 ceph-rgw/templates/deployment-rgw.yaml            | 2 ++
 ceph-rgw/templates/job-bootstrap.yaml             | 2 ++
@ -156,7 +157,7 @@ index d04d8fff..b312e4e9 100644
       - image_repo_sync
 
 labels:
-+  isApplication: false
+  isApplication: true
   job:
     node_selector_key: openstack-control-plane
     node_selector_value: enabled
@ -206,7 +207,7 @@ index c42cdac4..c531b1cf 100644
           cpu: "2000m"
 
 labels:
-+  isApplication: false
+  isApplication: true
   server:
     node_selector_key: openstack-control-plane
     node_selector_value: enabled
@ -237,7 +238,7 @@ index 3c2bad6e..9cd24011 100644
 release_group: null
 
 labels:
-+  isApplication: false
+  isApplication: true
   agent:
     libvirt:
       node_selector_key: openstack-compute-node
@ -266,7 +267,7 @@ index 64af4c05..8694f3b7 100644
       - image_repo_sync
 
 labels:
-+  isApplication: false
+  isApplication: true
   server:
     node_selector_key: openstack-control-plane
     node_selector_value: enabled
@ -295,7 +296,7 @@ index 90167a0d..3f782371 100644
     host_path: /var/lib/openstack-helm/mongodb
 
 labels:
-+  isApplication: false
+  isApplication: true
   server:
     node_selector_key: openstack-control-plane
     node_selector_value: enabled
@ -362,7 +363,7 @@ index e24db892..aa9b52ff 100644
 
 ---
 labels:
-+  isApplication: false
+  isApplication: true
   server:
     node_selector_key: openstack-control-plane
     node_selector_value: enabled
--- a/openstack-helm/debian/deb_folder/patches/0021-Add-app.starlingx.io-component-label-to-pods.patch
+++ b/openstack-helm/debian/deb_folder/patches/0021-Add-app.starlingx.io-component-label-to-pods.patch
@ -2,9 +2,6 @@ From bb808625cede886b7a3b5bc16fb6643babf2af3a Mon Sep 17 00:00:00 2001
 From: dbarbosa <david.barbosabastos@windriver.com>
 Date: Tue, 19 Dec 2023 10:01:29 -0300
 Subject: [PATCH] Add app.starlingx.io/component label to pods
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit

 Add the label app.starlingx.io/component to the pods and allow the
 value to be updated via "system helm-override-update". This change
@ -18,6 +15,8 @@ different from true or false, the label will not change.
 By default, all pods start with the value platform.

 Signed-off-by: David Bastos <david.barbosabastos@windriver.com>
+[ Updated "isApplication" labels values to "true" ]
+Signed-off-by: Thales Elero Cervi <thaleselero.cervi@windriver.com>
 ---
 aodh/templates/cron-job-alarms-cleaner.yaml              | 6 ++++++
 aodh/templates/deployment-api.yaml                       | 2 ++
@ -225,7 +224,7 @@ index 660bc26f..5da6eb61 100644
 release_group: null
 
 labels:
-+  isApplication: false
+  isApplication: true
   api:
     node_selector_key: openstack-control-plane
     node_selector_value: enabled
@ -270,7 +269,7 @@ index 09e21983..9bea5035 100644
 
 ---
 labels:
-+  isApplication: false
+  isApplication: true
   api:
     node_selector_key: openstack-control-plane
     node_selector_value: enabled
@ -452,7 +451,7 @@ index ddc5d632..0496c2cc 100644
 storage: ceph
 
 labels:
-+  isApplication: false
+  isApplication: true
   api:
     node_selector_key: openstack-control-plane
     node_selector_value: enabled
@ -542,7 +541,7 @@ index d15b77ac..ed8fd754 100644
 storage: swift
 
 labels:
-+  isApplication: false
+  isApplication: true
   api:
     node_selector_key: openstack-control-plane
     node_selector_value: enabled
@ -723,7 +722,7 @@ index ce61e7dd..5a0e4cba 100644
 release_group: null
 
 labels:
-+  isApplication: false
+  isApplication: true
   api:
     node_selector_key: openstack-control-plane
     node_selector_value: enabled
@ -783,7 +782,7 @@ index 1ca7c365..7aa8519d 100644
 release_group: null
 
 labels:
-+  isApplication: false
+  isApplication: true
   dashboard:
     node_selector_key: openstack-control-plane
     node_selector_value: enabled
@ -846,7 +845,7 @@ index 89fe1aec..39643ae8 100644
 helm3_hook: true
 
 labels:
-+  isApplication: false
+  isApplication: true
   api:
     node_selector_key: openstack-control-plane
     node_selector_value: enabled
@ -1009,7 +1008,7 @@ index ace7e976..2eea531d 100644
 
 ---
 labels:
-+  isApplication: false
+  isApplication: true
   api:
     node_selector_key: openstack-control-plane
     node_selector_value: enabled
@ -1253,7 +1252,7 @@ index c71a40cf..9f8666fc 100644
       - image_repo_sync
 
 labels:
-+  isApplication: false
+  isApplication: true
   agent:
     dhcp:
       node_selector_key: openstack-control-plane
@ -1535,7 +1534,7 @@ index 63b8d02f..0d964c53 100644
 release_group: null
 
 labels:
-+  isApplication: false
+  isApplication: true
   agent:
     compute:
       node_selector_key: openstack-compute-node
@ -1565,7 +1564,7 @@ index 4a702ace..35f4849c 100644
 release_group: null
 
 labels:
-+  isApplication: false
+  isApplication: true
   api:
     node_selector_key: openstack-control-plane
     node_selector_value: enabled
--- a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/helm-charts/clients/values.yaml
+++ b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/helm-charts/clients/values.yaml
@ -24,7 +24,7 @@ images:
      - image_repo_sync

 labels:
-  isApplication: false
+  isApplication: true
  openstack_clients:
    node_selector_key: openstack-control-plane
    node_selector_value: enabled
--- a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/helm-charts/dcdbsync/values.yaml
+++ b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/helm-charts/dcdbsync/values.yaml
@ -11,7 +11,7 @@
 replicaCount: 1

 labels:
-  isApplication: false
+  isApplication: true
  dcdbsync:
    node_selector_key: openstack-control-plane
    node_selector_value: enabled
--- a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/helm-charts/garbd/values.yaml
+++ b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/helm-charts/garbd/values.yaml
@ -85,7 +85,7 @@ images:
      - image_repo_sync

 labels:
-  isApplication: false
+  isApplication: true
  server:
    node_selector_key: openstack-compute-node
    node_selector_value: enabled
--- a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/helm-charts/keystone-api-proxy/values.yaml
+++ b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/helm-charts/keystone-api-proxy/values.yaml
@ -11,7 +11,7 @@
 replicaCount: 1

 labels:
-  isApplication: false
+  isApplication: true
  keystone_api_proxy:
    node_selector_key: openstack-control-plane
    node_selector_value: enabled
--- a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/helm-charts/nova-api-proxy/values.yaml
+++ b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/helm-charts/nova-api-proxy/values.yaml
@ -11,7 +11,7 @@
 replicaCount: 1

 labels:
-  isApplication: false
+  isApplication: true
  api_proxy:
    node_selector_key: openstack-control-plane
    node_selector_value: enabled
--- a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/helm-charts/pci-irq-affinity-agent/values.yaml
+++ b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/helm-charts/pci-irq-affinity-agent/values.yaml
@ -22,7 +22,7 @@ images:
      - dep_check

 labels:
-  isApplication: false
+  isApplication: true
  agent:
    pci_irq_affinity_agent:
      node_selector_key: openstack-compute-node