starlingx/openstack-armada-app
Code Issues Proposed changes

Add missing initial delay in readiness probes

Browse Source 
After applying STX-Openstack, some API pods are failing to pass the
readiness probe. This change adds a initialDelaySeconds value to the
deployment files of the services that are having this warning.

The liveness probe for these deployments already have a
initialDelaySeconds of 30 seconds, adding this value to the readiness
probe supresses this issue.

For the glance-api deployment, it was also required to add the
initialDelaySeconds to the liveness probe.

A review was proposed to the upstream openstack-helm repository [1], and
is currently under review. If the change is merged, this patch can be
ignored on future STX-Openstack development.

[1] https://review.opendev.org/c/openstack/openstack-helm/+/911015

Test Plan:
PASS: Build openstack-helm package
PASS: Build STX-Openstack application tarball
PASS: Upload / apply STX-Openstack application
PASS: Check the cinder-api, glance-api and heat-api pods and verify that
      there are no more readiness probe failures.

Closes-Bug: 2030908

Change-Id: If273f095ae0c589fa71faff7756d5f6861cfd264
Signed-off-by: Lucas de Ataides <lucas.deataidesbarreto@windriver.com>
This commit is contained in:
Lucas de Ataides 2024-03-04 12:14:48 -03:00
parent 834d9da342
commit 6a7c163cb0
2 changed files with 66 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

65
openstack-helm/debian/deb_folder/patches/0022-Add-missing-initial-delay-in-readiness-probes.patch Normal file
View File

@ -0,0 +1,65 @@
From b7c9f8d5326ad4722ef74ef4477bc9014a278e6f Mon Sep 17 00:00:00 2001
From: Lucas de Ataides <lucas.deataidesbarreto@windriver.com>
Date: Mon, 4 Mar 2024 12:09:40 -0300
Subject: [PATCH] Add missing initial delay in readiness probes
After applying STX-Openstack, some API pods are failing to pass the
readiness probe. This change adds a initialDelaySeconds value to the
deployment files of the services that are having this warning.
The liveness probe for these deployments already have a
initialDelaySeconds of 30 seconds, adding this value to the readiness
probe supresses this issue.
Signed-off-by: Lucas de Ataides <lucas.deataidesbarreto@windriver.com>
---
cinder/templates/deployment-api.yaml | 1 +
glance/templates/deployment-api.yaml | 2 ++
heat/templates/deployment-api.yaml | 1 +
3 files changed, 4 insertions(+)
diff --git a/cinder/templates/deployment-api.yaml b/cinder/templates/deployment-api.yaml
index 3f4e941a..2f747db0 100644
--- a/cinder/templates/deployment-api.yaml
+++ b/cinder/templates/deployment-api.yaml
@@ -109,6 +109,7 @@ spec:
scheme: {{ tuple "volume" "service" "api" . | include "helm-toolkit.endpoints.keystone_endpoint_scheme_lookup" | upper }}
path: /
port: {{ tuple "volume" "service" "api" . | include "helm-toolkit.endpoints.endpoint_port_lookup" }}
+ initialDelaySeconds: 30
livenessProbe:
httpGet:
scheme: {{ tuple "volume" "service" "api" . | include "helm-toolkit.endpoints.keystone_endpoint_scheme_lookup" | upper }}
diff --git a/glance/templates/deployment-api.yaml b/glance/templates/deployment-api.yaml
index 956639dc..a3405526 100644
--- a/glance/templates/deployment-api.yaml
+++ b/glance/templates/deployment-api.yaml
@@ -130,11 +130,13 @@ spec:
scheme: HTTP
path: /
port: {{ tuple "image" "service" "api" . | include "helm-toolkit.endpoints.endpoint_port_lookup" }}
+ initialDelaySeconds: 30
livenessProbe:
httpGet:
scheme: HTTP
path: /
port: {{ tuple "image" "service" "api" . | include "helm-toolkit.endpoints.endpoint_port_lookup" }}
+ initialDelaySeconds: 30
volumeMounts:
- name: pod-tmp
mountPath: /tmp
diff --git a/heat/templates/deployment-api.yaml b/heat/templates/deployment-api.yaml
index 178bedda..8f621e0e 100644
--- a/heat/templates/deployment-api.yaml
+++ b/heat/templates/deployment-api.yaml
@@ -86,6 +86,7 @@ spec:
scheme: {{ tuple "orchestration" "service" "api" . | include "helm-toolkit.endpoints.keystone_endpoint_scheme_lookup" | upper }}
path: /
port: {{ tuple "orchestration" "service" "api" . | include "helm-toolkit.endpoints.endpoint_port_lookup" }}
+ initialDelaySeconds: 30
livenessProbe:
httpGet:
scheme: {{ tuple "orchestration" "service" "api" . | include "helm-toolkit.endpoints.keystone_endpoint_scheme_lookup" | upper }}
--
2.25.1

1
openstack-helm/debian/deb_folder/patches/series
View File

@ -19,3 +19,4 @@
0019-Make-nova-address-search-optional.patch
0020-Add-service-tokens-for-Cinder-auth.patch
0021-Add-app.starlingx.io-component-label-to-pods.patch
0022-Add-missing-initial-delay-in-readiness-probes.patch