Update patch set 4
Patch Set 4: Code-Review+1
(6 comments)
Patch-set: 4
Reviewer: Gerrit User 33594 <33594@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
Attention: {"person_ident":"Gerrit User 27498 \u003c27498@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33594\u003e replied on the change"}
This commit is contained in:
Gerrit User 33594
Gerrit Code Review
parent
90a78fc852
commit
94fa58e931
|
|
@ -17,6 +17,24 @@
|
|||
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "3ad5759d_049af351",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 7,
|
||||
"author": {
|
||||
"id": 33594
|
||||
},
|
||||
"writtenOn": "2022-08-04T16:50:54Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "a60316be_7d4faeaa",
|
||||
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
|
|
@ -87,6 +105,24 @@
|
|||
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "f7f32bb4_a27e1a96",
|
||||
"filename": "openstack-helm-infra/centos/openstack-helm-infra.spec",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 95,
|
||||
"author": {
|
||||
"id": 33594
|
||||
},
|
||||
"writtenOn": "2022-08-04T16:50:54Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "96f064cc_fdbcbef9",
|
||||
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -104,6 +140,24 @@
|
|||
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "40ffa522_c22c4835",
|
||||
"filename": "openstack-helm/centos/openstack-helm.spec",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 78,
|
||||
"author": {
|
||||
"id": 33594
|
||||
},
|
||||
"writtenOn": "2022-08-04T16:50:54Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "5e9de660_48f8e4b8",
|
||||
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -121,6 +175,24 @@
|
|||
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "5c1251d4_8de414bf",
|
||||
"filename": "openstack-helm/centos/openstack-helm.spec",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 104,
|
||||
"author": {
|
||||
"id": 33594
|
||||
},
|
||||
"writtenOn": "2022-08-04T16:50:54Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "b34d064c_3c989e0d",
|
||||
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -137,6 +209,24 @@
|
|||
"message": "this should not be here, app_tarball should be created at \"openstack-armada-app/stx-openstack-helm/centos/stx-openstack-helm.spec\"\n\nwhat you want to do here is just create two charts, I would name them osh-helm2 (for armada) and osh (for fluxcd)\n\nAfter you have these chart tarballs available at ${RPM_BUILD_ROOT}%{helm_folder} at \"openstack-armada-app/stx-openstack-helm/centos/stx-openstack-helm.spec\" you use the two different chart tarballs to create stx-openstack-armada-app and stx-openstack-fluxcd-app",
|
||||
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "8e5130c6_3ac22814",
|
||||
"filename": "openstack-helm/centos/openstack-helm.spec",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 133,
|
||||
"author": {
|
||||
"id": 33594
|
||||
},
|
||||
"writtenOn": "2022-08-04T16:50:54Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "33163587_f8d358e2",
|
||||
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "1f6e5a19_9298e9bc",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 33594
|
||||
},
|
||||
"writtenOn": "2022-08-04T16:50:54Z",
|
||||
"side": 1,
|
||||
"message": "Great job here Pedro! LGMT",
|
||||
"revId": "b492e4535023ef570c410f14147968622922fc8a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue