starlingx
/
openstack-armada-app
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 32349 <32349@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 32349 2022-08-03 14:42:43 +00:00 committed by Gerrit Code Review
parent fe7b2cea2b
commit ceab1eeded
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
2159b1d169eca84f93a0b0e302c04f41284ec4f7
View File

@ -1,5 +1,22 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "b41619b1_bc0c9893",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 32349
},
"writtenOn": "2022-08-03T14:42:43Z",
"side": 1,
"message": "Now that I stopped to think better of it, I think we should test providing the helm3_hook values directly on the application manifest.yaml (for armada) and on each chart\u0027s static-overrides (for fluxcd). If this works, we could remove this patch for good and reduce complexity.",
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {