From f3f74c96bedd6aa318e2e5b4ab99af633fa903b9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20Falc=C3=A3o?= Date: Tue, 18 Oct 2022 15:30:04 -0300 Subject: [PATCH] Adding disableWait flag into HelmRelease resources Some pods where getting stuck due the following cyclic dependency: The api pod where stuck in the Init state awaiting for jobs to be executed. Jobs had a post-install hook, meaning that will only be executed when all resources are loaded into Kubernetes [1]. Since the api pod where stuck in a Init state, the jobs never spawns and consequently the api pod. To solve this issue it was added a disableWait flag into the HelmReleases, meaning that the waiting for resources to be ready after a helm install has been performed will be disabled [2], allowing the api pods and jobs to spawn. Test Plan: PASS - Build stx-openstack tarball. PASS - Upload/apply stx-openstack. PASS - Remove/delete stx-openstack. [1] - https://helm.sh/docs/topics/charts_hooks/ [2] - https://fluxcd.io/flux/components/helm/helmreleases/ Signed-off-by: Rafael Falcao Change-Id: Iacc7544a5b3ecc8729aca991741255c105d5eb22 --- .../stx-openstack-helm-fluxcd/manifests/cinder/helmrelease.yaml | 2 ++ .../stx-openstack-helm-fluxcd/manifests/glance/helmrelease.yaml | 2 ++ .../stx-openstack-helm-fluxcd/manifests/heat/helmrelease.yaml | 2 ++ .../manifests/keystone/helmrelease.yaml | 2 ++ .../manifests/neutron/helmrelease.yaml | 2 ++ .../stx-openstack-helm-fluxcd/manifests/nova/helmrelease.yaml | 2 ++ .../manifests/placement/helmrelease.yaml | 2 ++ 7 files changed, 14 insertions(+) diff --git a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/cinder/helmrelease.yaml b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/cinder/helmrelease.yaml index 86163b45..89e96d58 100644 --- a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/cinder/helmrelease.yaml +++ b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/cinder/helmrelease.yaml @@ -26,8 +26,10 @@ spec: enable: false install: disableHooks: false + disableWait: true upgrade: disableHooks: false + disableWait: true dependsOn: - name: glance namespace: openstack diff --git a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/glance/helmrelease.yaml b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/glance/helmrelease.yaml index 8ed6d840..6ade0249 100644 --- a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/glance/helmrelease.yaml +++ b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/glance/helmrelease.yaml @@ -26,8 +26,10 @@ spec: enable: false install: disableHooks: false + disableWait: true upgrade: disableHooks: false + disableWait: true dependsOn: - name: keystone namespace: openstack diff --git a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/heat/helmrelease.yaml b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/heat/helmrelease.yaml index f00ceffe..74ac2743 100644 --- a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/heat/helmrelease.yaml +++ b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/heat/helmrelease.yaml @@ -26,8 +26,10 @@ spec: enable: false install: disableHooks: false + disableWait: true upgrade: disableHooks: false + disableWait: true dependsOn: - name: placement namespace: openstack diff --git a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/keystone/helmrelease.yaml b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/keystone/helmrelease.yaml index fe50f00d..c23ed948 100644 --- a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/keystone/helmrelease.yaml +++ b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/keystone/helmrelease.yaml @@ -26,8 +26,10 @@ spec: enable: false install: disableHooks: false + disableWait: true upgrade: disableHooks: false + disableWait: true dependsOn: - name: rabbitmq namespace: openstack diff --git a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/neutron/helmrelease.yaml b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/neutron/helmrelease.yaml index 288bb7b2..a95550d6 100644 --- a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/neutron/helmrelease.yaml +++ b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/neutron/helmrelease.yaml @@ -26,8 +26,10 @@ spec: enable: false install: disableHooks: false + disableWait: true upgrade: disableHooks: false + disableWait: true dependsOn: - name: placement namespace: openstack diff --git a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/nova/helmrelease.yaml b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/nova/helmrelease.yaml index 5f5bb196..0fa3df39 100644 --- a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/nova/helmrelease.yaml +++ b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/nova/helmrelease.yaml @@ -26,8 +26,10 @@ spec: enable: false install: disableHooks: false + disableWait: true upgrade: disableHooks: false + disableWait: true dependsOn: - name: placement namespace: openstack diff --git a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/placement/helmrelease.yaml b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/placement/helmrelease.yaml index 5354e96c..ba4107f4 100644 --- a/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/placement/helmrelease.yaml +++ b/stx-openstack-helm-fluxcd/stx-openstack-helm-fluxcd/manifests/placement/helmrelease.yaml @@ -26,8 +26,10 @@ spec: enable: false install: disableHooks: false + disableWait: true upgrade: disableHooks: false + disableWait: true dependsOn: - name: cinder namespace: openstack