250 lines
8.3 KiB
Plaintext
250 lines
8.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a60316be_7d4faeaa",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 33594
|
|
},
|
|
"writtenOn": "2022-08-03T16:53:59Z",
|
|
"side": 1,
|
|
"message": "I don\u0027t think this change is really doing any kind of \"FluxCD conversion\". It is rather finding a way to build osh(-i) with helmv2 or with helmv3 hooks, so maybe the title could be rephrased later",
|
|
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "3ad5759d_049af351",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 33594
|
|
},
|
|
"writtenOn": "2022-08-04T16:50:54Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "a60316be_7d4faeaa",
|
|
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "b41619b1_bc0c9893",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 32349
|
|
},
|
|
"writtenOn": "2022-08-03T14:42:43Z",
|
|
"side": 1,
|
|
"message": "Now that I stopped to think better of it, I think we should test providing the helm3_hook values directly on the application manifest.yaml (for armada) and on each chart\u0027s static-overrides (for fluxcd). If this works, we could remove this patch for good and reduce complexity.",
|
|
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "858c4aa0_8b01e3c1",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 33594
|
|
},
|
|
"writtenOn": "2022-08-03T16:48:42Z",
|
|
"side": 1,
|
|
"message": "This approach sounds reasonable to me and I also agree that it if it works this should be the way we go here. Reducing the number of patches we carry along is always welcome :)",
|
|
"parentUuid": "b41619b1_bc0c9893",
|
|
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "af666c87_4414bf76",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 33594
|
|
},
|
|
"writtenOn": "2022-08-03T16:51:43Z",
|
|
"side": 1,
|
|
"message": "If this works, this change can remove the patch for good and update the manifest.yaml for armada.\nThe fluxcd part can be handled within https://review.opendev.org/c/starlingx/openstack-armada-app/+/840432/ and the related chain of changes.",
|
|
"parentUuid": "858c4aa0_8b01e3c1",
|
|
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "054053b8_2bbb8cad",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 33987
|
|
},
|
|
"writtenOn": "2022-08-04T16:54:39Z",
|
|
"side": 1,
|
|
"message": "I went for this approach. This way, less changes are necessary and we can remove the patch. The fluxcd part is handled by the commit Thales mentioned. Thanks for all the inputs, Lucas, Thiago and Thales!",
|
|
"parentUuid": "af666c87_4414bf76",
|
|
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "96f064cc_fdbcbef9",
|
|
"filename": "openstack-helm-infra/centos/openstack-helm-infra.spec",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 95,
|
|
"author": {
|
|
"id": 27498
|
|
},
|
|
"writtenOn": "2022-08-03T14:21:28Z",
|
|
"side": 1,
|
|
"message": "trailing whitespace",
|
|
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f7f32bb4_a27e1a96",
|
|
"filename": "openstack-helm-infra/centos/openstack-helm-infra.spec",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 95,
|
|
"author": {
|
|
"id": 33594
|
|
},
|
|
"writtenOn": "2022-08-04T16:50:54Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "96f064cc_fdbcbef9",
|
|
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "5e9de660_48f8e4b8",
|
|
"filename": "openstack-helm/centos/openstack-helm.spec",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 78,
|
|
"author": {
|
|
"id": 27498
|
|
},
|
|
"writtenOn": "2022-08-03T14:21:28Z",
|
|
"side": 1,
|
|
"message": "this spec does not define an application, it just creates helm charts so naming should be openstack_helm2_chart_tarball and openstack_helm_chart_tarball or something like this",
|
|
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "40ffa522_c22c4835",
|
|
"filename": "openstack-helm/centos/openstack-helm.spec",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 78,
|
|
"author": {
|
|
"id": 33594
|
|
},
|
|
"writtenOn": "2022-08-04T16:50:54Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "5e9de660_48f8e4b8",
|
|
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b34d064c_3c989e0d",
|
|
"filename": "openstack-helm/centos/openstack-helm.spec",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 104,
|
|
"author": {
|
|
"id": 27498
|
|
},
|
|
"writtenOn": "2022-08-03T14:21:28Z",
|
|
"side": 1,
|
|
"message": "this is not an app tarball it is a chart_tarball",
|
|
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5c1251d4_8de414bf",
|
|
"filename": "openstack-helm/centos/openstack-helm.spec",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 104,
|
|
"author": {
|
|
"id": 33594
|
|
},
|
|
"writtenOn": "2022-08-04T16:50:54Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "b34d064c_3c989e0d",
|
|
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "33163587_f8d358e2",
|
|
"filename": "openstack-helm/centos/openstack-helm.spec",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 133,
|
|
"author": {
|
|
"id": 27498
|
|
},
|
|
"writtenOn": "2022-08-03T14:21:28Z",
|
|
"side": 1,
|
|
"message": "this should not be here, app_tarball should be created at \"openstack-armada-app/stx-openstack-helm/centos/stx-openstack-helm.spec\"\n\nwhat you want to do here is just create two charts, I would name them osh-helm2 (for armada) and osh (for fluxcd)\n\nAfter you have these chart tarballs available at ${RPM_BUILD_ROOT}%{helm_folder} at \"openstack-armada-app/stx-openstack-helm/centos/stx-openstack-helm.spec\" you use the two different chart tarballs to create stx-openstack-armada-app and stx-openstack-fluxcd-app",
|
|
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8e5130c6_3ac22814",
|
|
"filename": "openstack-helm/centos/openstack-helm.spec",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 133,
|
|
"author": {
|
|
"id": 33594
|
|
},
|
|
"writtenOn": "2022-08-04T16:50:54Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "33163587_f8d358e2",
|
|
"revId": "2159b1d169eca84f93a0b0e302c04f41284ec4f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |