fa16c5c8ff
Patch Set 11: Code-Review+2
(1 comment)
Patch-set: 11
Reviewer: Gerrit User 26026 <26026@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 5fe9342cc0ab09413ffddace473c2b3d419cf7e0
Attention: {"person_ident":"Gerrit User 26026 \u003c26026@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_26026\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 34387 \u003c34387@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_26026\u003e replied on the change"}
240 lines
7.6 KiB
Plaintext
240 lines
7.6 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4ebdcc46_0602c0a6",
|
|
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010740-kata-containers-reintegration.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 24,
|
|
"author": {
|
|
"id": 26026
|
|
},
|
|
"writtenOn": "2023-12-18T18:54:30Z",
|
|
"side": 1,
|
|
"message": "Is there not also still \u0027feature\u0027 differences/limitations with Kata Containers compared to convential containers ?\ne.g.\nThere used to be limitations with SRIOV/Multus devices, IPv6 (I think this is fixed now), HugePage support, cpu policy and cpu/memory footprint.\n\nI have an old StarlingX SLIDE DECK describing those limitations.\n\nIt would be good to get an updated view of any feature/functional limitations that Kata Containers has. I.e. can I do everything in kata containers that I can do in a runc container ?",
|
|
"range": {
|
|
"startLine": 23,
|
|
"startChar": 0,
|
|
"endLine": 24,
|
|
"endChar": 15
|
|
},
|
|
"revId": "89f8ee7429f2fc0365dcad63d5a40c8bac9150a7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "555c22cd_d67ef7d7",
|
|
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010740-kata-containers-reintegration.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 24,
|
|
"author": {
|
|
"id": 34769
|
|
},
|
|
"writtenOn": "2023-12-19T18:47:15Z",
|
|
"side": 1,
|
|
"message": "I believe we can mention these limitations in kata-containers documentation, since we will need to update it. What do you think? This way we can have more time to investigate these limitations in detail.",
|
|
"parentUuid": "4ebdcc46_0602c0a6",
|
|
"range": {
|
|
"startLine": 23,
|
|
"startChar": 0,
|
|
"endLine": 24,
|
|
"endChar": 15
|
|
},
|
|
"revId": "89f8ee7429f2fc0365dcad63d5a40c8bac9150a7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b1cc2eeb_a884a03c",
|
|
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010740-kata-containers-reintegration.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 24,
|
|
"author": {
|
|
"id": 26026
|
|
},
|
|
"writtenOn": "2023-12-20T12:45:55Z",
|
|
"side": 1,
|
|
"message": "Agree.\n\nJust indicate in this spec ... maybe in \u0027Work Items\u0027 that you will investigate and document limitations with kata-containers.",
|
|
"parentUuid": "555c22cd_d67ef7d7",
|
|
"range": {
|
|
"startLine": 23,
|
|
"startChar": 0,
|
|
"endLine": 24,
|
|
"endChar": 15
|
|
},
|
|
"revId": "89f8ee7429f2fc0365dcad63d5a40c8bac9150a7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f1fd9025_b511c726",
|
|
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010740-kata-containers-reintegration.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 24,
|
|
"author": {
|
|
"id": 34387
|
|
},
|
|
"writtenOn": "2023-12-20T19:19:49Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "b1cc2eeb_a884a03c",
|
|
"range": {
|
|
"startLine": 23,
|
|
"startChar": 0,
|
|
"endLine": 24,
|
|
"endChar": 15
|
|
},
|
|
"revId": "89f8ee7429f2fc0365dcad63d5a40c8bac9150a7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "09bff9ec_d48bc6e1",
|
|
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010740-kata-containers-reintegration.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 93,
|
|
"author": {
|
|
"id": 26026
|
|
},
|
|
"writtenOn": "2023-12-18T18:54:30Z",
|
|
"side": 1,
|
|
"message": "This feature should do some characterization of the performance degradation when using kata containers versus runc/containerd containers",
|
|
"range": {
|
|
"startLine": 93,
|
|
"startChar": 0,
|
|
"endLine": 93,
|
|
"endChar": 72
|
|
},
|
|
"revId": "89f8ee7429f2fc0365dcad63d5a40c8bac9150a7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b87c1cab_a63a8d8c",
|
|
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010740-kata-containers-reintegration.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 93,
|
|
"author": {
|
|
"id": 34387
|
|
},
|
|
"writtenOn": "2023-12-20T19:19:49Z",
|
|
"side": 1,
|
|
"message": "I\u0027ve referenced two papers that analyze that performance gap.",
|
|
"parentUuid": "09bff9ec_d48bc6e1",
|
|
"range": {
|
|
"startLine": 93,
|
|
"startChar": 0,
|
|
"endLine": 93,
|
|
"endChar": 72
|
|
},
|
|
"revId": "89f8ee7429f2fc0365dcad63d5a40c8bac9150a7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "0a3bb368_4e9c5424",
|
|
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010740-kata-containers-reintegration.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 93,
|
|
"author": {
|
|
"id": 26026
|
|
},
|
|
"writtenOn": "2024-01-02T12:15:17Z",
|
|
"side": 1,
|
|
"message": "Acknowledged",
|
|
"parentUuid": "b87c1cab_a63a8d8c",
|
|
"range": {
|
|
"startLine": 93,
|
|
"startChar": 0,
|
|
"endLine": 93,
|
|
"endChar": 72
|
|
},
|
|
"revId": "89f8ee7429f2fc0365dcad63d5a40c8bac9150a7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d1fc9286_5ff727bb",
|
|
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010740-kata-containers-reintegration.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 126,
|
|
"author": {
|
|
"id": 34769
|
|
},
|
|
"writtenOn": "2023-12-18T12:16:16Z",
|
|
"side": 1,
|
|
"message": "complete with username",
|
|
"revId": "89f8ee7429f2fc0365dcad63d5a40c8bac9150a7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "79a31580_d51e31fa",
|
|
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010740-kata-containers-reintegration.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 126,
|
|
"author": {
|
|
"id": 34387
|
|
},
|
|
"writtenOn": "2023-12-18T12:42:06Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "d1fc9286_5ff727bb",
|
|
"revId": "89f8ee7429f2fc0365dcad63d5a40c8bac9150a7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2697bd43_3e3fa63c",
|
|
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010740-kata-containers-reintegration.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 130,
|
|
"author": {
|
|
"id": 34769
|
|
},
|
|
"writtenOn": "2023-12-18T12:16:16Z",
|
|
"side": 1,
|
|
"message": "complete with username",
|
|
"revId": "89f8ee7429f2fc0365dcad63d5a40c8bac9150a7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "3433af15_c54d3d5d",
|
|
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010740-kata-containers-reintegration.rst",
|
|
"patchSetId": 9
|
|
},
|
|
"lineNbr": 130,
|
|
"author": {
|
|
"id": 34387
|
|
},
|
|
"writtenOn": "2023-12-18T12:42:06Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "2697bd43_3e3fa63c",
|
|
"revId": "89f8ee7429f2fc0365dcad63d5a40c8bac9150a7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |