Update patch set 1
Patch Set 1: Code-Review-1 (3 comments) Patch-set: 1 Reviewer: Gerrit User 28486 <28486@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1 Attention: {"person_ident":"Gerrit User 28486 \u003c28486@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Tee Ngo replied on the change"}
This commit is contained in:
parent
bf543b32c2
commit
17b993702f
|
@ -17,6 +17,69 @@
|
|||
"revId": "d7a64e12e5296e89ec6dda734ef95cbec8db3624",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "dd5703e3_1cfad453",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 9,
|
||||
"author": {
|
||||
"id": 28486
|
||||
},
|
||||
"writtenOn": "2021-11-25T14:02:50Z",
|
||||
"side": 1,
|
||||
"message": "Invalid commit message as it does not reflect the title as well as the intention of the specified task. Please rework.",
|
||||
"range": {
|
||||
"startLine": 9,
|
||||
"startChar": 0,
|
||||
"endLine": 9,
|
||||
"endChar": 139
|
||||
},
|
||||
"revId": "d7a64e12e5296e89ec6dda734ef95cbec8db3624",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "38179b57_1a3ffc3f",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 28486
|
||||
},
|
||||
"writtenOn": "2021-11-25T14:02:50Z",
|
||||
"side": 1,
|
||||
"message": "Please -1 WF if testing is not complete.",
|
||||
"revId": "d7a64e12e5296e89ec6dda734ef95cbec8db3624",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "f89f5009_6de66c3b",
|
||||
"filename": "puppet-manifests/src/modules/platform/manifests/params.pp",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 63,
|
||||
"author": {
|
||||
"id": 28486
|
||||
},
|
||||
"writtenOn": "2021-11-25T14:02:50Z",
|
||||
"side": 1,
|
||||
"message": "What services that run on the system controller really require adjustment? Please make change in their puppet files.\n\nAside from Al\u0027s comments below, it does not make sense that the new min for $eng_workers_by_6 is larger than $eng_workers_by_5",
|
||||
"range": {
|
||||
"startLine": 63,
|
||||
"startChar": 0,
|
||||
"endLine": 63,
|
||||
"endChar": 56
|
||||
},
|
||||
"revId": "d7a64e12e5296e89ec6dda734ef95cbec8db3624",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
Loading…
Reference in New Issue