starlingx
/
stx-puppet
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review+2

(3 comments)

Patch-set: 3
Reviewer: Gerrit User 15435 <15435@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2
This commit is contained in:
Gerrit User 15435 2021-11-25 20:51:32 +00:00 committed by Gerrit Code Review
parent 41ea261489
commit 797f091609
1 changed files with 61 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
2103d859de3f86a31f0a4f084a132bf34e937c1b Normal file
View File

@ -0,0 +1,61 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "220f57bb_3f9407c8",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 19,
"author": {
"id": 15435
},
"writtenOn": "2021-11-25T20:51:32Z",
"side": 1,
"message": "Usually Change-Id is be located with the story/task/bug/signed-off-by near the end of the commit message",
"revId": "2103d859de3f86a31f0a4f084a132bf34e937c1b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4b130a35_7c7640d9",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 29,
"author": {
"id": 15435
},
"writtenOn": "2021-11-25T20:51:32Z",
"side": 1,
"message": "You could probably just include this one line as part of your: \u0027following message appears\u0027 comment above.\n\nHowever, since this is submitted for a task rather than a bug, I am fine with keeping this as well.",
"range": {
"startLine": 29,
"startChar": 0,
"endLine": 29,
"endChar": 73
},
"revId": "2103d859de3f86a31f0a4f084a132bf34e937c1b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "971ea685_63a11bfa",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 15435
},
"writtenOn": "2021-11-25T20:51:32Z",
"side": 1,
"message": "changes seem fine to me. I have only minor nits related to the commit message",
"revId": "2103d859de3f86a31f0a4f084a132bf34e937c1b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}