From e01bfe5fed04ec30bf6a6a8b43ca611d3b99942d Mon Sep 17 00:00:00 2001 From: "Kyale, Eliud" <Eliud.Kyale@windriver.com> Date: Tue, 19 Nov 2024 09:51:35 -0500 Subject: [PATCH] Show detailed grub update logs Show detailed logs that indicate which kernel arguments have been updated in order to assist in determining reboot cause. kernel arguments require a reboot that affects performance and timing Test plan: PASS - AIO-SX: iso install PASS - AIO-SX: manually edit kernel parameters and trigger puppet audit observe logs and reboot Closes-Bug : 2089028 Change-Id: I721cadf3dfb725bf3722eacca7a039cf3c4e31d1 Signed-off-by: Kyale, Eliud <Eliud.Kyale@windriver.com> --- .../platform/lib/puppet/parser/functions/check_grub_config.rb | 2 +- puppet-manifests/src/modules/platform/manifests/compute.pp | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/puppet-manifests/src/modules/platform/lib/puppet/parser/functions/check_grub_config.rb b/puppet-manifests/src/modules/platform/lib/puppet/parser/functions/check_grub_config.rb index c6840432f..cba9cd0bf 100644 --- a/puppet-manifests/src/modules/platform/lib/puppet/parser/functions/check_grub_config.rb +++ b/puppet-manifests/src/modules/platform/lib/puppet/parser/functions/check_grub_config.rb @@ -25,7 +25,7 @@ module Puppet::Parser::Functions expected.split().each do |element| value = cmd_array.include?(element) if value == false - Puppet.debug("#{element} is not presented in #{cmd}") + Puppet.info("#{element} is not presented in #{cmd}") return value end end diff --git a/puppet-manifests/src/modules/platform/manifests/compute.pp b/puppet-manifests/src/modules/platform/manifests/compute.pp index e7dc3aa4e..b3d04ca87 100644 --- a/puppet-manifests/src/modules/platform/manifests/compute.pp +++ b/puppet-manifests/src/modules/platform/manifests/compute.pp @@ -143,6 +143,8 @@ class platform::compute::grub::update logoutput => true, } } elsif($::osfamily == 'Debian') { + notice("Removing kernel args: ${to_be_removed}") + notice("Adding kernel args: ${truncated_grub_updates}") exec { 'Remove the cpu arguments from /boot/efi/EFI/BOOT/boot.env': command => "/usr/local/bin/puppet-update-grub-env.py --remove-kernelparams '${to_be_removed}'", }