starlingx
/
stx-puppet
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 33278 \u003c33278@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Vinicius Lopes da Silva replied on the change"}
Attention: {"person_ident":"Gerrit User 28434 \u003c28434@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Vinicius Lopes da Silva replied on the change"}
This commit is contained in:
Gerrit User 33278 2021-11-26 17:29:48 +00:00 committed by Gerrit Code Review
parent eb21bc61f0
commit 9b842e033f
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
e223b96ac4ce4518d93636005bb28429b2aea165
View File

@ -16,6 +16,24 @@
"message": "I think the root cause is that we\u0027re restarting the process outside of SM. Why not just use sm-safe-restart? eg platform::sm::restart {\u0027ceph-mon\u0027:}",
"revId": "e223b96ac4ce4518d93636005bb28429b2aea165",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "fa01db61_0283d9e7",
"filename": "puppet-manifests/src/modules/platform/manifests/ceph.pp",
"patchSetId": 3
},
"lineNbr": 961,
"author": {
"id": 33278
},
"writtenOn": "2021-11-26T17:29:48Z",
"side": 0,
"message": "I tried command \"sm-restart service ceph-mon\". In AIO-DX it didn\u0027t have any negative impact. For AIO-SX it didn\u0027t restart the monitor. \n\nThe restart operation is not required when adding \"mon_host\" in the config file. It was only required for the monitor in AIO-SX which is now being handled by running ceph commands directly.",
"parentUuid": "3bd196e5_fc93220e",
"revId": "e223b96ac4ce4518d93636005bb28429b2aea165",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}