starlingx
/
stx-puppet
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
CC: Gerrit User 15435 <15435@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 34221 \u003c34221@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Al Bailey replied on the change"}
This commit is contained in:
Gerrit User 15435 2021-11-24 18:32:34 +00:00 committed by Gerrit Code Review
parent 20eaddd56c
commit c6be7c1d23
1 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
3e890f37458a0fef8acbdcfb36e8ac4f3b15c03c Normal file
View File

@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "04c12552_1bbb3982",
"filename": "puppet-manifests/src/modules/platform/manifests/params.pp",
"patchSetId": 1
},
"lineNbr": 92,
"author": {
"id": 15435
},
"writtenOn": "2021-11-24T18:32:34Z",
"side": 1,
"message": "I am surprised puppet lint allows this.\nI thought puppet only allows you to assign a variable once (respecting if blocks). so line 64 or 83 would have already set eng_workers_by_2",
"range": {
"startLine": 92,
"startChar": 5,
"endLine": 92,
"endChar": 22
},
"revId": "3e890f37458a0fef8acbdcfb36e8ac4f3b15c03c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}