starlingx
/
tools
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 28410 <28410@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Reviewer: Gerrit User 31683 <31683@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Reviewer: Gerrit User 33394 <33394@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Reviewer: Gerrit User 32685 <32685@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 32685 \u003c32685@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32651\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28410 \u003c28410@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32651\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 33394 \u003c33394@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32651\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 31683 \u003c31683@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32651\u003e replied on the change"}
This commit is contained in:
Gerrit User 32651 2022-08-15 03:03:51 +00:00 committed by Gerrit Code Review
parent ced59e03bf
commit 4b1fb79cdc
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
76d87e2833fe82fcde7276ea12a8988aa300f5ff Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "e329dae6_d4be7d5d",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 32651
},
"writtenOn": "2022-08-15T03:03:51Z",
"side": 1,
"message": "In bullseye\u0027s docker image, to save disk space, file /etc/apt/apt.conf.d/docker-clean sets as below:\n# Since for most Docker users, package installs happen in \"docker build\" steps,\n# they essentially become individual layers due to the way Docker handles\n# layering, especially using CoW filesystems. What this means for us is that\n# the caches that APT keeps end up just wasting space in those layers, making\n# our layers unnecessarily large (especially since we\u0027ll normally never use\n# these caches again and will instead just \"docker build\" again and make a brand\n# new image).\n\n# Ideally, these would just be invoking \"apt-get clean\", but in our testing,\n# that ended up being cyclic and we got stuck on APT\u0027s lock, so we get this fun\n# creation that\u0027s essentially just \"apt-get clean\".\nDPkg::Post-Invoke { \"rm -f /var/cache/apt/archives/*.deb /var/cache/apt/archives/partial/*.deb /var/cache/apt/*.bin || true\"; };\nAPT::Update::Post-Invoke { \"rm -f /var/cache/apt/archives/*.deb /var/cache/apt/archives/partial/*.deb /var/cache/apt/*.bin || true\"; };\n...\n\nFor privilege users like root, it always works in order. While in our use case, we run apt update as common user with a fake rootdir like \"cache \u003d apt.update(rootdir\u003d\u0027/tmp/xxx\u0027)\". This operation will also trigger the `rm` operation above thus cause the \"Permission Denied\" message. This message is harmless but will confuse our developers. So just suppress it.",
"revId": "76d87e2833fe82fcde7276ea12a8988aa300f5ff",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}