starlingx
/
tools
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(14 comments)

Minor comments.
I suspect most of this code will be refactored once people have had a change to try it out, so I am not focusing too much about the naming or code layout.

Patch-set: 3
This commit is contained in:
Gerrit User 15435 2019-02-27 22:16:33 +00:00 committed by Gerrit Code Review
parent e947113e7d
commit 522a9170f7
1 changed files with 260 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

260
8508f3b29be05afd97cd34ae4946046a20674909 Normal file
View File

@ -0,0 +1,260 @@
{
"comments": [
{
"key": {
"uuid": "9fdfeff1_e0720be3",
"filename": "deployment/virtualbox/pybox/README.txt",
"patchSetId": 3
},
"lineNbr": 70,
"author": {
"id": 15435
},
"writtenOn": "2019-02-27T22:16:33Z",
"side": 1,
"message": "nit: trailing whitespace.",
"revId": "8508f3b29be05afd97cd34ae4946046a20674909",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_6035bbf6",
"filename": "deployment/virtualbox/pybox/configs/aio-sx/lab_setup.conf",
"patchSetId": 3
},
"lineNbr": 3,
"author": {
"id": 15435
},
"writtenOn": "2019-02-27T22:16:33Z",
"side": 1,
"message": "nit: trailing whitespace.",
"revId": "8508f3b29be05afd97cd34ae4946046a20674909",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_80045f19",
"filename": "deployment/virtualbox/pybox/configs/aio-sx/lab_setup.conf",
"patchSetId": 3
},
"lineNbr": 13,
"author": {
"id": 15435
},
"writtenOn": "2019-02-27T22:16:33Z",
"side": 1,
"message": "I think that with the new proxy settings, there might need to be a default for those fields now.",
"revId": "8508f3b29be05afd97cd34ae4946046a20674909",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_4329a187",
"filename": "deployment/virtualbox/pybox/configs/aio-sx/lab_setup.sh",
"patchSetId": 3
},
"lineNbr": 332,
"author": {
"id": 15435
},
"writtenOn": "2019-02-27T22:16:33Z",
"side": 1,
"message": "nit: trailing whitespace",
"revId": "8508f3b29be05afd97cd34ae4946046a20674909",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_23701da4",
"filename": "deployment/virtualbox/pybox/configs/aio-sx/lab_setup.sh",
"patchSetId": 3
},
"lineNbr": 762,
"author": {
"id": 15435
},
"writtenOn": "2019-02-27T22:16:33Z",
"side": 1,
"message": "nit: trailing whitespace",
"revId": "8508f3b29be05afd97cd34ae4946046a20674909",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_e36535e2",
"filename": "deployment/virtualbox/pybox/configs/aio-sx/lab_setup.sh",
"patchSetId": 3
},
"lineNbr": 763,
"author": {
"id": 15435
},
"writtenOn": "2019-02-27T22:16:33Z",
"side": 1,
"message": "nit: trailing whitespace",
"revId": "8508f3b29be05afd97cd34ae4946046a20674909",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_a35bad1f",
"filename": "deployment/virtualbox/pybox/configs/aio-sx/lab_setup.sh",
"patchSetId": 3
},
"lineNbr": 790,
"author": {
"id": 15435
},
"writtenOn": "2019-02-27T22:16:33Z",
"side": 1,
"message": "nit: trailing whitespace",
"revId": "8508f3b29be05afd97cd34ae4946046a20674909",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_639f05b4",
"filename": "deployment/virtualbox/pybox/configs/aio-sx/lab_setup.sh",
"patchSetId": 3
},
"lineNbr": 2581,
"author": {
"id": 15435
},
"writtenOn": "2019-02-27T22:16:33Z",
"side": 1,
"message": "nit: trailing whitespace",
"revId": "8508f3b29be05afd97cd34ae4946046a20674909",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_e393f5a1",
"filename": "deployment/virtualbox/pybox/configs/aio-sx/lab_setup.sh",
"patchSetId": 3
},
"lineNbr": 3684,
"author": {
"id": 15435
},
"writtenOn": "2019-02-27T22:16:33Z",
"side": 1,
"message": "There are a number of places in this file where this compute naming pattern is used. \nAs a future enhancement, it might be good to declare this as a constant in case a new naming pattern is being used (ie: worker)",
"range": {
"startLine": 3684,
"startChar": 29,
"endLine": 3684,
"endChar": 36
},
"revId": "8508f3b29be05afd97cd34ae4946046a20674909",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_c3227152",
"filename": "deployment/virtualbox/pybox/configs/aio-sx/lab_setup.sh",
"patchSetId": 3
},
"lineNbr": 4760,
"author": {
"id": 15435
},
"writtenOn": "2019-02-27T22:16:33Z",
"side": 1,
"message": "nit: date",
"range": {
"startLine": 4760,
"startChar": 39,
"endLine": 4760,
"endChar": 43
},
"revId": "8508f3b29be05afd97cd34ae4946046a20674909",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_638e252f",
"filename": "deployment/virtualbox/pybox/configs/aio-sx/lab_setup.sh",
"patchSetId": 3
},
"lineNbr": 5890,
"author": {
"id": 15435
},
"writtenOn": "2019-02-27T22:16:33Z",
"side": 1,
"message": "nit: Maybe change Couldnt to Could not, unless you want to try adding the \u0027 (which might need escape characters)",
"range": {
"startLine": 5890,
"startChar": 29,
"endLine": 5890,
"endChar": 36
},
"revId": "8508f3b29be05afd97cd34ae4946046a20674909",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_43b9a1c9",
"filename": "deployment/virtualbox/pybox/configs/aio-sx/lab_setup.sh",
"patchSetId": 3
},
"lineNbr": 5903,
"author": {
"id": 15435
},
"writtenOn": "2019-02-27T22:16:33Z",
"side": 1,
"message": "For my own reference, this is located in an aio-sx folder.\nIs this script shared amongst multiple installations, including non AIO configs?",
"revId": "8508f3b29be05afd97cd34ae4946046a20674909",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_c3d111fd",
"filename": "deployment/virtualbox/pybox/configs/aio-sx/lab_setup.sh",
"patchSetId": 3
},
"lineNbr": 5974,
"author": {
"id": 15435
},
"writtenOn": "2019-02-27T22:16:33Z",
"side": 1,
"message": "I think this section will end up being revisited once containers goes live.",
"revId": "8508f3b29be05afd97cd34ae4946046a20674909",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_03fdd96c",
"filename": "deployment/virtualbox/pybox/configs/aio-sx/lab_setup.sh",
"patchSetId": 3
},
"lineNbr": 6585,
"author": {
"id": 15435
},
"writtenOn": "2019-02-27T22:16:33Z",
"side": 1,
"message": "Is this going away?",
"revId": "8508f3b29be05afd97cd34ae4946046a20674909",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}