Update patch set 3
Patch Set 3: Code-Review+1 (3 comments) Patch-set: 3 Reviewer: Gerrit User 33377 <33377@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+1, 5ba9e34282d846c2ea59c443bf77330dc4ac9740 Attention: {"person_ident":"Gerrit User 33377 \u003c33377@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33377\u003e replied on the change"}
This commit is contained in:
parent
ecbf9a0b70
commit
c7f9fbcc0c
|
@ -0,0 +1,67 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "c473ee79_3cdcf948",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 33377
|
||||
},
|
||||
"writtenOn": "2024-03-01T16:04:56Z",
|
||||
"side": 1,
|
||||
"message": "Hi Jiping,\n\nI have two minor comments, but the commit looks good to me in general.\n\nAssigning a +1 vote (in case my understanding was incorrect).\n\nThanks!\n\nVefa",
|
||||
"revId": "dae2e2e68ac5cf82f2ffc9c099a5496bec4ea63a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "8d012144_9d7f98fc",
|
||||
"filename": "debian-mirror-tools/config/debian/common/base-initramfs-bullseye.yaml",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 43,
|
||||
"author": {
|
||||
"id": 33377
|
||||
},
|
||||
"writtenOn": "2024-03-01T16:04:56Z",
|
||||
"side": 1,
|
||||
"message": "Minor: It would be good to mention in the commit message that the ice driver is kept enabled to allow packaging the DDP firmware.",
|
||||
"range": {
|
||||
"startLine": 43,
|
||||
"startChar": 2,
|
||||
"endLine": 43,
|
||||
"endChar": 5
|
||||
},
|
||||
"revId": "dae2e2e68ac5cf82f2ffc9c099a5496bec4ea63a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "28614136_8c96e946",
|
||||
"filename": "debian-mirror-tools/config/debian/common/base-initramfs-bullseye.yaml",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 44,
|
||||
"author": {
|
||||
"id": 33377
|
||||
},
|
||||
"writtenOn": "2024-03-01T16:04:56Z",
|
||||
"side": 1,
|
||||
"message": "Minor: Do we need both of the ice and ice-rt packages, or is only the ice package sufficient to ensure that the DDP firwmare is packaged?",
|
||||
"range": {
|
||||
"startLine": 44,
|
||||
"startChar": 0,
|
||||
"endLine": 44,
|
||||
"endChar": 2
|
||||
},
|
||||
"revId": "dae2e2e68ac5cf82f2ffc9c099a5496bec4ea63a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue