ecbf9a0b70
Patch Set 3: Code-Review+1
(1 comment)
Patch-set: 3
Reviewer: Gerrit User 33394 <33394@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, e385a775aceb7e3164e674e40d30a04808356231
Attention: {"person_ident":"Gerrit User 32752 \u003c32752@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33394\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 33394 \u003c33394@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33394\u003e replied on the change"}
57 lines
2.0 KiB
Plaintext
57 lines
2.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "cff91e3f_8ffd6752",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 10,
|
|
"author": {
|
|
"id": 33394
|
|
},
|
|
"writtenOn": "2024-02-27T14:06:34Z",
|
|
"side": 1,
|
|
"message": "This commit message doesn\u0027t really cover the \"why?\" and isn\u0027t clear about the \"what?\". Are you attempting to say\n\n- \"Remove OOT drivers from initramfs\" is clear\n- \"before enable OOT drivers\" is unclear\n- \"we will use the in-tree drivers in this stage\" is mostly clear\n\nSo why are the OOT drivers going to be enabled and available at some point in the future? Why exactly are the OOT drivers being replaced by the in-tree drivers?\n\nPlease expand on this commit log. Imaging you are reading this 1 year from now, so ensure you have enough information to allow future you to understand why and what you did here.",
|
|
"revId": "5d33cd69d852eeebafbc1294e4301958f138b7a7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "54bc9d8d_ee7afb12",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 10,
|
|
"author": {
|
|
"id": 32752
|
|
},
|
|
"writtenOn": "2024-02-28T02:49:25Z",
|
|
"side": 1,
|
|
"message": "Thanks for the suggestions. I will expand the commit log.",
|
|
"parentUuid": "cff91e3f_8ffd6752",
|
|
"revId": "5d33cd69d852eeebafbc1294e4301958f138b7a7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "122e9229_1e954c1f",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 10,
|
|
"author": {
|
|
"id": 33394
|
|
},
|
|
"writtenOn": "2024-02-28T14:34:03Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "54bc9d8d_ee7afb12",
|
|
"revId": "5d33cd69d852eeebafbc1294e4301958f138b7a7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |