starlingx/update
Code Issues Proposed changes

Remove duplicate message about system-local-ca private key

Browse Source 
This commit removes the duplicate message for system-local-ca private
key in deploy precheck as it appears twice in the code.

Test Plan:

PASS: check 22.12 -> 24.09 deploy precheck do not have dup message.
PASS: check 24.09 -> 25.09 deploy precheck do not have dup message.

Story: 2010676
Task: 51631

Change-Id: I6c2c24c38ce65a729002e0fe5dec8e1284db2ce2
Signed-off-by: Luis Eduardo Bonatti <luizeduardo.bonatti@windriver.com>
This commit is contained in:
Luis Eduardo Bonatti 2025-01-28 19:06:20 -03:00 committed by Luis Eduardo Bonatti
parent d16a439273
commit 82d6acd312
1 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
software/scripts/deploy-precheck
View File

@ -325,28 +325,6 @@ class UpgradeHealthCheck(HealthCheck):
% ', '.join(missing_patches)
health_ok = health_ok and success
# check if system-local-ca's private key is RSA
if upgrade_utils.get_distributed_cloud_role() == 'subcloud':
# system-local-ca in subclouds either match the systemcontroller's,
# or it will be changed to match in upgrade activation
LOG.info("Checking system-local-ca's private key is not required for subclouds.")
success = True
else:
success = self._check_local_issuer_rsa_private_key()
if not success:
LOG.error("system-local-ca's private key is either not RSA or not valid.")
output += 'Platform Issuer: [%s]\n' % (HealthCheck.FAIL_MSG)
output += ('-> Platform Issuer (system-local-ca) TLS private key is not valid. '
'Only RSA keys are supported.\n'
' Please perform the \'Update system-local-ca or Migrate Platform '
'Certificates to use Cert Manager\'\n'
' procedure to update the Platform Issuer, providing a valid RSA '
'cert/key to be used by the issuer.\n')
else:
LOG.info("system-local-ca has a valid private key.")
health_ok = health_ok and success
return health_ok, output
def _check_required_patches(self, required_patches):