starlingx/update
Code Issues Proposed changes

Revert "major release state change exception handling"

Browse Source 
This reverts commit 795d909b4d6bca1b2cdfabd95242cd40aac66b00.

Reason for revert: This commit is reverted because the exception
could accidentally introduce new state machine transitions, which
might be undefined.

An error log will be added instead to
https://review.opendev.org/c/starlingx/update/+/926468

Story: 2010676
Task: 50799

Change-Id: Ie7be94833b26695400fd38792be5fb8448603405
Signed-off-by: sshathee <shunmugam.shatheesh@windriver.com>
This commit is contained in:
S Shatheesh 2024-09-23 10:08:37 +00:00 committed by sshathee
parent 2db18a6212
commit d347a5d068
1 changed files with 3 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
software/software/software_controller.py
View File

@ -840,24 +840,11 @@ class SWMessageDeployStateChanged(messages.PatchMessage):
if self.deploy_state:
LOG.info("Received deploy state changed to %s, agent %s" %
(self.deploy_state, self.agent))
try:
sc.deploy_state_changed(self.deploy_state)
except Exception as e:
LOG.exception("Deploy state change failed: %s" % str(e))
# Error occurred while transitioning state to start-done
# so change it to start-failed
if self.deploy_state == DEPLOY_STATES.START_DONE:
sc.deploy_state_changed(DEPLOY_STATES.START_FAILED)
# Error occurred while transitioning state to activate-done
# so change it to activate-failed
if self.deploy_state == DEPLOY_STATES.ACTIVATE_DONE:
sc.deploy_state_changed(DEPLOY_STATES.ACTIVATE_FAILED)
(self.deploy_state, self.agent))
sc.deploy_state_changed(self.deploy_state)
else:
LOG.info("Received %s deploy host state changed to %s, agent %s" %
(self.hostname, self.host_state, self.agent))
(self.hostname, self.host_state, self.agent))
sc.host_deploy_state_changed(self.hostname, self.host_state)
sock.sendto(str.encode("OK"), addr)