{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "99fe7582_aea7b2ce",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 4
      },
      "lineNbr": 0,
      "author": {
        "id": 9926
      },
      "writtenOn": "2022-08-31T12:03:32Z",
      "side": 1,
      "message": "pending responses to Bob\u0027s comments",
      "revId": "ce80e6c9c999a88d2bacdb93a4d766b4bbcdfa77",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "f7129646_2a90be1b",
        "filename": "sw-patch/cgcs-patch/cgcs_patch/patch_agent.py",
        "patchSetId": 4
      },
      "lineNbr": 34,
      "author": {
        "id": 28459
      },
      "writtenOn": "2022-08-31T06:24:13Z",
      "side": 1,
      "message": "Consider changing to \"patch_deployments_cleaned\". Might be clearer what it currently signifies",
      "range": {
        "startLine": 34,
        "startChar": 0,
        "endLine": 34,
        "endChar": 31
      },
      "revId": "ce80e6c9c999a88d2bacdb93a4d766b4bbcdfa77",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "1d944bed_00123c9c",
        "filename": "sw-patch/cgcs-patch/cgcs_patch/patch_agent.py",
        "patchSetId": 4
      },
      "lineNbr": 34,
      "author": {
        "id": 31484
      },
      "writtenOn": "2022-08-31T15:25:24Z",
      "side": 1,
      "message": "The purpose of this flag is to differentiate between a process restart after reboot and subsequent reboots the patch-agent may encounter (due to any reason). We want deployments to only be deleted during a reboot case.\nI would suggest that we keep the names as is so that the flag can be reused in the future when we have to run some tasks after a reboot.",
      "parentUuid": "f7129646_2a90be1b",
      "range": {
        "startLine": 34,
        "startChar": 0,
        "endLine": 34,
        "endChar": 31
      },
      "revId": "ce80e6c9c999a88d2bacdb93a4d766b4bbcdfa77",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "71b4cfa0_f516b020",
        "filename": "sw-patch/cgcs-patch/cgcs_patch/patch_agent.py",
        "patchSetId": 4
      },
      "lineNbr": 697,
      "author": {
        "id": 28459
      },
      "writtenOn": "2022-08-31T06:24:13Z",
      "side": 1,
      "message": "Should we set the flag at the end of delete_older_deployments() or at line 420 above incase there is an exception when running the ostree commands so that we re-try?",
      "revId": "ce80e6c9c999a88d2bacdb93a4d766b4bbcdfa77",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "ab055b63_63ed79dd",
        "filename": "sw-patch/cgcs-patch/cgcs_patch/patch_agent.py",
        "patchSetId": 4
      },
      "lineNbr": 697,
      "author": {
        "id": 31484
      },
      "writtenOn": "2022-08-31T15:25:24Z",
      "side": 1,
      "message": "If an error occurs and we aren\u0027t able to delete deployments, we want to wait till the next reboot for the cleanup. (this method runs if a patch agent is restarted as well and we don\u0027t want the deployment deletion to run in that case)\n\nConsider a case where we have an in-service patch applied and a new ostree deployment is added for it. If in the next few days, the system becomes unstable and patch-agent has been restarted (this isn\u0027t a reboot), we want to be sure that this restart is not because of a system reboot. Otherwise we might end up deleting deployments that are referenced by the mounted deployment and reach a state from where it would be impossible to recover the system.",
      "parentUuid": "71b4cfa0_f516b020",
      "revId": "ce80e6c9c999a88d2bacdb93a4d766b4bbcdfa77",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}