{ "comments": [ { "unresolved": true, "key": { "uuid": "23e13708_ec41e9b0", "filename": "software/software/software_controller.py", "patchSetId": 19 }, "lineNbr": 3085, "author": { "id": 28466 }, "writtenOn": "2024-04-11T15:08:59Z", "side": 1, "message": "by caching the alarm, it may not be able to clear the alarm if the software-controller-daemon restarts, or swact. Should retrieve the alarm when periodically.", "revId": "addbd1dddf487dadafc3a5d5fdf48feeb5008439", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "294fdef0_15b3db6f", "filename": "software/software/software_controller.py", "patchSetId": 19 }, "lineNbr": 3085, "author": { "id": 34895 }, "writtenOn": "2024-04-11T18:58:42Z", "side": 1, "message": "I added the call to fm service to sync the alarm with cache when the thread starts. This can handle the case where the software-controller-daemon restarts and swact happens. The rest is the same as this method is called every 30 sec.", "parentUuid": "23e13708_ec41e9b0", "revId": "addbd1dddf487dadafc3a5d5fdf48feeb5008439", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] }