A Day One bug in the patching apply/remove semantic checks around the
required patches means the specified list of patches can be truncated
in certain scenarios. A local variable used in a for-loop iteration
has the same name as another local variable in a slightly broader scope,
causing the broader scoped variable to be overwritten in certain
scenarios.
The APIs have semantics that are intended to do the following checks:
- From every patch in the arg list, build up a list of required patches.
- if a required patch is in the arg list, it doesn't get added to the
"required patches" dict, since it's being operated on
- Loop over the required patches dict, checking the states
- This is where the bug exists, as the loop inadvertently overwrites
the patch list
So the following scenarios will work fine and not have an issue:
- No patches are applied on the system, all patches being applied in one
command. The required patches dict is empty, because all patches are
in the argument list, so the patch list does not get corrupted.
- Patches are applied one by one on the system. The patch list gets
overwritten, but it's overwritten with the same single patch.
The following scenario runs into problems:
- Some patches applied on the system. Two or more patches, at least one
of which has dependencies, and dependency lists are not complete lists
of all previous patches. The patch list is corrupted with a partial
list of patches, and not all specified patches end up getting applied.
Story: 2002859
Task: 22808
Change-Id: I09ce3af9ede39f163a3ddd1fc64fc154716d1d60
Signed-off-by: Don Penney <don.penney@windriver.com>
Signed-off-by: Jack Ding <jack.ding@windriver.com>
cae40d14c2