starlingx
/
utilities
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(5 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 36205 \u003c36205@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36205\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 33549 \u003c33549@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36205\u003e replied on the change"}
This commit is contained in:
Gerrit User 36205 2024-04-25 20:16:47 +00:00 committed by Gerrit Code Review
parent 6a16436f9a
commit 2262df4018
1 changed files with 89 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

89
4f44c035e788d9b3f172ef71fa01d6b0daec50fc Normal file
View File

@ -0,0 +1,89 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "d102024b_6fb427ae",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 19,
"author": {
"id": 36205
},
"writtenOn": "2024-04-25T20:16:47Z",
"side": 1,
"message": "It may be worth doing a separate test for serial and graphical",
"revId": "4f44c035e788d9b3f172ef71fa01d6b0daec50fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "52566621_388fd04d",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 27,
"author": {
"id": 36205
},
"writtenOn": "2024-04-25T20:16:47Z",
"side": 1,
"message": "I had created a task for this, also there\u0027s a dependency on the kickstarts update:\n\nStory: 2011100\nTask: 49970\n\nDepends-on: https://review.opendev.org/c/starlingx/metal/+/914995",
"revId": "4f44c035e788d9b3f172ef71fa01d6b0daec50fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "984aae10_1e383e39",
"filename": "utilities/platform-util/scripts/gen-prestaged-iso.sh",
"patchSetId": 2
},
"lineNbr": 291,
"author": {
"id": 36205
},
"writtenOn": "2024-04-25T20:16:47Z",
"side": 1,
"message": "We\u0027ll need additional labels to make sure we identify and cover all the following installs:\n\nPrestage install\nPrestage cloud-init, Debian Controller Install\nPrestage cloud-init Debian All-in-one Install\nPrestage cloud-init Debian All-in-one Install (lowlatency)\n\n\nI will update this in a follow-up to this change.",
"revId": "4f44c035e788d9b3f172ef71fa01d6b0daec50fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "81e0f7bb_086f3b7a",
"filename": "utilities/platform-util/scripts/gen-prestaged-iso.sh",
"patchSetId": 2
},
"lineNbr": 292,
"author": {
"id": 36205
},
"writtenOn": "2024-04-25T20:16:47Z",
"side": 1,
"message": "Closing \u0027}\u0027 should be \u0027)\u0027",
"revId": "4f44c035e788d9b3f172ef71fa01d6b0daec50fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ab756455_7a8a28a1",
"filename": "utilities/platform-util/scripts/gen-prestaged-iso.sh",
"patchSetId": 2
},
"lineNbr": 298,
"author": {
"id": 36205
},
"writtenOn": "2024-04-25T20:16:47Z",
"side": 1,
"message": "Closing \u0027}\u0027 should be \u0027)\u0027",
"revId": "4f44c035e788d9b3f172ef71fa01d6b0daec50fc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}