starlingx
/
utilities
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(2 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 31292 \u003c31292@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31292\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28676 \u003c28676@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31292\u003e replied on the change"}
This commit is contained in:
Gerrit User 31292 2024-02-01 16:02:47 +00:00 committed by Gerrit Code Review
parent 519c2dc072
commit 2f221d4eda
2 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
8efae620d3967cfdd44132e073564e274e864aa1
View File

@ -16,6 +16,24 @@
"message": "I\u0027m seeing people are making the comment line too short ... while this is not big deal, but making them within the 72 char range is still highly recommended.",
"revId": "8efae620d3967cfdd44132e073564e274e864aa1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "27eec5fe_2c85cfaa",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 19,
"author": {
"id": 31292
},
"writtenOn": "2024-02-01T16:02:47Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "2e2a055b_f83e0dcd",
"revId": "8efae620d3967cfdd44132e073564e274e864aa1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

24
909d715ccdb215e8812de0e62712cb62bf91ae73
View File

@ -70,6 +70,30 @@
},
"revId": "909d715ccdb215e8812de0e62712cb62bf91ae73",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cb218b02_b4fdec44",
"filename": "utilities/platform-util/scripts/show-certs.sh",
"patchSetId": 2
},
"lineNbr": 178,
"author": {
"id": 31292
},
"writtenOn": "2024-02-01T16:02:47Z",
"side": 1,
"message": "why do we want to add \":\" for else case? then both commands in if and else are same, then no reason to add if,else block\n\nPrintCertInfo-fromGenericSecret() is also used for all cert types like oidc which is greping for \"dex-ca.pem\". \n\nfor WRA , we are calling this as below\n\nPrintCertInfo-fromGenericSecret \"Internal Analytics CA Certificate\" \"monitor\" \"mon-elastic-services-secrets\" \"ca.crt\"\nPrintCertInfo-fromGenericSecret \"External Analytics CA Certificate\" \"monitor\" \"mon-elastic-services-secrets\" \"ext-ca.crt\"\nPrintCertInfo-fromGenericSecret \"External Kibana Certificate\" \"monitor\" \"mon-elastic-services-secrets\" \"kibana.crt\"",
"parentUuid": "c5119be9_c6657a72",
"range": {
"startLine": 177,
"startChar": 0,
"endLine": 178,
"endChar": 159
},
"revId": "909d715ccdb215e8812de0e62712cb62bf91ae73",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}