starlingx
/
utilities
Code Issues Proposed changes

Update patch set 8 

Patch Set 8:

(2 comments)

Patch-set: 8
Attention: {"person_ident":"Gerrit User 34857 \u003c34857@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_34857\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34857\u003e replied on the change"}
This commit is contained in:
Gerrit User 34857 2022-10-13 16:37:20 +00:00 committed by Gerrit Code Review
parent 03f7c6f67d
commit 40aa4716a0
2 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
958237c2295ac6a39dedf25a9043d32d2daf7468
View File

@ -16,6 +16,24 @@
"message": "Is this reference SYSINV_CONFIG_FILE still needed?",
"revId": "958237c2295ac6a39dedf25a9043d32d2daf7468",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "fde87a4a_f0b6e9a4",
"filename": "ceph/ceph-manager/ceph-manager/ceph_manager/constants.py",
"patchSetId": 5
},
"lineNbr": 67,
"author": {
"id": 34857
},
"writtenOn": "2022-10-13T16:37:20Z",
"side": 0,
"message": "I searched the code base, this constant is not in use anymore. I\u0027m removing it too.",
"parentUuid": "49c8fe60_b8b567cb",
"revId": "958237c2295ac6a39dedf25a9043d32d2daf7468",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

18
a40faccd718a8da8beded77e17fb64d9a4508bf4
View File

@ -16,6 +16,24 @@
"message": "Test Plan is required as per: https://docs.starlingx.io/developer_resources/code-submission-guide.html#pre-review-and-pre-submission-testing",
"revId": "a40faccd718a8da8beded77e17fb64d9a4508bf4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9890e577_3052486e",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 28,
"author": {
"id": 34857
},
"writtenOn": "2022-10-13T16:37:20Z",
"side": 1,
"message": "Done",
"parentUuid": "0c80f376_be3deee1",
"revId": "a40faccd718a8da8beded77e17fb64d9a4508bf4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}