starlingx
/
utilities
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(4 comments)

Patch-set: 1
Reviewer: Gerrit User 28464 <28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28464 \u003c28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"}
This commit is contained in:
Gerrit User 28464 2022-11-11 15:02:07 +00:00 committed by Gerrit Code Review
parent 764c422440
commit 58485f7e41
1 changed files with 87 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

87
d7b608e5d2632d97f517d8637fb6c94730bb73ae
View File

@ -16,6 +16,93 @@
"message": "was verification confirmed that collect is rejected when provided with incorrect password?",
"revId": "d7b608e5d2632d97f517d8637fb6c94730bb73ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f72ce9f1_d124b5c9",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 24,
"author": {
"id": 28464
},
"writtenOn": "2022-11-11T15:02:07Z",
"side": 1,
"message": "Yes it was and it passes with printing only Invalid Password error.\nThis test case should be added to the list.",
"parentUuid": "544e3e54_284e6cad",
"revId": "d7b608e5d2632d97f517d8637fb6c94730bb73ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "44701b7c_32ca7631",
"filename": "tools/collector/scripts/collect",
"patchSetId": 1
},
"lineNbr": 1089,
"author": {
"id": 28464
},
"writtenOn": "2022-11-11T15:02:07Z",
"side": 1,
"message": "This new function should have a header like the ones below it ; eg: lines 1121 to 1131",
"range": {
"startLine": 1089,
"startChar": 9,
"endLine": 1089,
"endChar": 22
},
"revId": "d7b608e5d2632d97f517d8637fb6c94730bb73ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "28be9472_493035fc",
"filename": "tools/collector/scripts/collect",
"patchSetId": 1
},
"lineNbr": 1091,
"author": {
"id": 28464
},
"writtenOn": "2022-11-11T15:02:07Z",
"side": 1,
"message": "This is not required. There is no passed argument.",
"range": {
"startLine": 1091,
"startChar": 3,
"endLine": 1091,
"endChar": 18
},
"revId": "d7b608e5d2632d97f517d8637fb6c94730bb73ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9949b130_a01894f7",
"filename": "tools/collector/scripts/collect",
"patchSetId": 1
},
"lineNbr": 1096,
"author": {
"id": 28464
},
"writtenOn": "2022-11-11T15:02:07Z",
"side": 1,
"message": "This timeout should be 60 seconds to account for overload leading to a slow password prompt case that should be accepted.",
"range": {
"startLine": 1096,
"startChar": 16,
"endLine": 1096,
"endChar": 18
},
"revId": "d7b608e5d2632d97f517d8637fb6c94730bb73ae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}