starlingx
/
utilities
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(1 comment)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 33549 \u003c33549@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33549\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 36205 \u003c36205@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33549\u003e replied on the change"}
This commit is contained in:
Gerrit User 33549 2023-12-05 22:18:34 +00:00 committed by Gerrit Code Review
parent 9ab6420b1f
commit 5effabec25
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
57d57607cc642bba050295aec958db966ab9bb97
View File

@ -16,6 +16,24 @@
"message": "Minor: Is it also worth mentioning rvmc-config in here and in examples? I came looking for it here to figure out dcmanager use of the script.",
"revId": "57d57607cc642bba050295aec958db966ab9bb97",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c83c2d11_e1753abe",
"filename": "utilities/platform-util/scripts/ipmicap.sh",
"patchSetId": 5
},
"lineNbr": 58,
"author": {
"id": 33549
},
"writtenOn": "2023-12-05T22:18:34Z",
"side": 1,
"message": "It is kind of hidden isn\u0027t it. The rvmc config file is owned by root and has sensitive data in it, so it is only there more for our internal use-case. This is why I left it out of the help, which is more focused on interactive use. I\u0027m going to leave it out unless anyone else thinks it should be in this help.",
"parentUuid": "f728dd3e_e1a252b5",
"revId": "57d57607cc642bba050295aec958db966ab9bb97",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}