starlingx
/
utilities
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review-1

(3 comments)

Patch-set: 5
Reviewer: Gerrit User 28715 <28715@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 27498 \u003c27498@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Jim Gauld replied on the change"}
Attention: {"person_ident":"Gerrit User 28715 \u003c28715@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Jim Gauld replied on the change"}
This commit is contained in:
Gerrit User 28715 2021-10-15 17:17:12 +00:00 committed by Gerrit Code Review
parent 0cca912cd2
commit 74d5199499
1 changed files with 65 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
f3e596a8173d276648b0fed7ec2970fd42f1d6cb
View File

@ -1,6 +1,70 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "4d745ad9_da25c265",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 10,
"author": {
"id": 28715
},
"writtenOn": "2021-10-15T17:17:12Z",
"side": 1,
"message": "This is vague, spell out what the issue was (high level).",
"range": {
"startLine": 9,
"startChar": 0,
"endLine": 10,
"endChar": 34
},
"revId": "f3e596a8173d276648b0fed7ec2970fd42f1d6cb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5bca9ecd_94dea563",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 12,
"author": {
"id": 28715
},
"writtenOn": "2021-10-15T17:17:12Z",
"side": 1,
"message": "Be more specific.",
"range": {
"startLine": 11,
"startChar": 42,
"endLine": 12,
"endChar": 5
},
"revId": "f3e596a8173d276648b0fed7ec2970fd42f1d6cb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "cca09d15_986cd3c9",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 28715
},
"writtenOn": "2021-10-15T17:17:12Z",
"side": 1,
"message": "Please indicate what testing configurations you covered for SR-IOV/PCI-PT in commit message.\n\n* since the commit indicates issues in some cases (eg, multiple interfaces, PCI-PT), just make it obvious how you actually tested that\n* did you test with Intel crypto device QAT? Really should.\n",
"revId": "f3e596a8173d276648b0fed7ec2970fd42f1d6cb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c11a2b1e_5f397a99",
"filename": "utilities/pci-irq-affinity-agent/pci_irq_affinity/pci_irq_affinity/guest.py",
@ -14,8 +78,7 @@
"side": 1,
"message": "Why is this function being implemented here? I think it could be a private module function.",
"revId": "f3e596a8173d276648b0fed7ec2970fd42f1d6cb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}