starlingx
/
utilities
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(2 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 34605 \u003c34605@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_34605\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 33549 \u003c33549@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34605\u003e replied on the change"}
This commit is contained in:
Gerrit User 34605 2023-12-05 03:20:03 +00:00 committed by Gerrit Code Review
parent b525ab7416
commit 90550f7d41
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
2cbb1daedfe37af73345711486a01bf10189bfa3 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "49f9b8e0_434c98ab",
"filename": "utilities/platform-util/scripts/ipmicap.sh",
"patchSetId": 4
},
"lineNbr": 104,
"author": {
"id": 34605
},
"writtenOn": "2023-12-05T03:20:03Z",
"side": 1,
"message": "log_info() { \u003e\u00262 echo \"$(get_logdate) $*\"; }\nPlease add timestamps to all logs at every level.",
"revId": "2cbb1daedfe37af73345711486a01bf10189bfa3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e1c04709_49d720d5",
"filename": "utilities/platform-util/scripts/ipmicap.sh",
"patchSetId": 4
},
"lineNbr": 172,
"author": {
"id": 34605
},
"writtenOn": "2023-12-05T03:20:03Z",
"side": 1,
"message": "If this would fail if another user is actively monitoring logs? It seems there\u0027s no way to detect this scenario and kick out or terminate another user\u0027s session?",
"revId": "2cbb1daedfe37af73345711486a01bf10189bfa3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}