starlingx
/
utilities
Code Issues Proposed changes

Update patch set 7 

Patch Set 7:

(3 comments)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 33549 \u003c33549@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34119\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 34119 \u003c34119@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_34119\u003e replied on the change"}
This commit is contained in:
Gerrit User 34119 2022-11-08 01:53:00 +00:00 committed by Gerrit Code Review
parent dc3203bef8
commit 91564dbbcf
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
bf8d1ab241997c9290e02116638d45f8575d487d
View File

@ -23,6 +23,30 @@
"revId": "bf8d1ab241997c9290e02116638d45f8575d487d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8341769b_b23b54fc",
"filename": "/COMMIT_MSG",
"patchSetId": 6
},
"lineNbr": 25,
"author": {
"id": 34119
},
"writtenOn": "2022-11-08T01:53:00Z",
"side": 1,
"message": "Done",
"parentUuid": "37f566e6_6ad02eea",
"range": {
"startLine": 25,
"startChar": 0,
"endLine": 25,
"endChar": 13
},
"revId": "bf8d1ab241997c9290e02116638d45f8575d487d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +70,30 @@
"revId": "bf8d1ab241997c9290e02116638d45f8575d487d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "33637ec1_713c3cfd",
"filename": "utilities/platform-util/scripts/gen-prestaged-iso.sh",
"patchSetId": 6
},
"lineNbr": 176,
"author": {
"id": 34119
},
"writtenOn": "2022-11-08T01:53:00Z",
"side": 1,
"message": "This is legacy code. In this particular case, normalized_path really is doing nothing. removing.",
"parentUuid": "f510b428_a7360361",
"range": {
"startLine": 176,
"startChar": 40,
"endLine": 176,
"endChar": 54
},
"revId": "bf8d1ab241997c9290e02116638d45f8575d487d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -68,6 +116,30 @@
},
"revId": "bf8d1ab241997c9290e02116638d45f8575d487d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "87bd6898_8ec3fe9d",
"filename": "utilities/platform-util/scripts/gen-prestaged-iso.sh",
"patchSetId": 6
},
"lineNbr": 178,
"author": {
"id": 34119
},
"writtenOn": "2022-11-08T01:53:00Z",
"side": 1,
"message": "It is used in line 207. This code is reused code from the centos prestage code. \nThe purpose of this code is to copy the md5 sum where required (like container images). Prefer to keep it, to avoid reinventing the code.",
"parentUuid": "4e1fd13f_2f892be5",
"range": {
"startLine": 178,
"startChar": 8,
"endLine": 178,
"endChar": 21
},
"revId": "bf8d1ab241997c9290e02116638d45f8575d487d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}