starlingx/utilities
Code Issues Proposed changes

Remove renewal check for WRA certificates

Browse Source 
In show-certs script to derive the renewal field for WRA certs
mon-elastic-services-secrets/ca.crt and
mon-elastic-services-secrets/ext-ca.crt, the contents are
compared with mon-elastic-services-ca-crt and
mon-elastic-services-extca-crt secrets respectively, this is
creating a confusion to the user from the show-certs script
output when WRA fails to update the certificates as per its
certificate management and also WRA certificates are managed by
cert-manager by default, so removing this condition and keeping
only secret exist check makes it clear for the user what is
expected from the script output.

TestCases:
PASS: Have different contents in mon-elastic-services-secrets/
      ca.crt and mon-elastic-services-ca-crt and notice the
      renewal field for mon-elastic-services-secrets/ca.crt
      shows as "Automatic"
PASS: Have different contents in mon-elastic-services-secrets/
      ext-ca.crt and mon-elastic-services-ext-ca-crt and notice the
      renewal field for mon-elastic-services-secrets/ext-ca.crt
      shows as "Automatic"

Closes-Bug: 2061014

Change-Id: Ib6e0627eda9b401210f2eda5c0fa8e613738a11e
Signed-off-by: amantri <ayyappa.mantri@windriver.com>
This commit is contained in:
amantri 2024-04-11 15:09:44 -04:00
parent af59ba9cb9
commit a79f2d06c8
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
utilities/platform-util/scripts/show-certs.sh
View File

@ -191,8 +191,7 @@ PrintCertInfo-fromGenericSecret () {
elif [[ "ext-ca.crt" == $SECRETFILE ]]; then
TLS_SECRET_NAME="mon-elastic-services-extca-crt"
fi
TLS_SECRET_VALUE=$(kubectl --kubeconfig /etc/kubernetes/admin.conf -n $NAMESPACE get secret $TLS_SECRET_NAME -o jsonpath='{.data.tls\.crt}')
if [[ $TLS_SECRET_VALUE == $SECRET_VALUE && $CERT_MANAGER_SECRETS == *$TLS_SECRET_NAME* ]]; then
if [[ $CERT_MANAGER_SECRETS == *$TLS_SECRET_NAME* ]]; then
RENEWAL="${GREEN}$AUTO_LABEL${RESET}"
fi
fi