starlingx
/
utilities
Code Issues Proposed changes

Update patch set 6 

Patch Set 6: Code-Review-1

(7 comments)

Patch-set: 6
Reviewer: Gerrit User 28459 <28459@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 24 \u003c24@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Bob Church replied on the change"}
Attention: {"person_ident":"Gerrit User 30852 \u003c30852@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Bob Church replied on the change"}
This commit is contained in:
Gerrit User 28459 2021-10-11 18:47:11 +00:00 committed by Gerrit Code Review
parent 4771eb68fb
commit aaaefc06d9
1 changed files with 135 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

135
fb7c9edc810a4c02c9942d6aeb0a96b5d1acfa29 Normal file
View File

@ -0,0 +1,135 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "b3a97fd6_55c2b6e9",
"filename": "utilities/platform-util/debian/deb_folder/control",
"patchSetId": 6
},
"lineNbr": 17,
"author": {
"id": 28459
},
"writtenOn": "2021-10-11T18:47:11Z",
"side": 1,
"message": "nit: Simple cleanup\nE: platform-util: description-synopsis-is-duplicated",
"revId": "fb7c9edc810a4c02c9942d6aeb0a96b5d1acfa29",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "52ab022d_64275a4d",
"filename": "utilities/platform-util/debian/deb_folder/control",
"patchSetId": 6
},
"lineNbr": 24,
"author": {
"id": 28459
},
"writtenOn": "2021-10-11T18:47:11Z",
"side": 1,
"message": "nit: Simple cleanup\nE: python3-platform-util: description-synopsis-is-duplicated",
"revId": "fb7c9edc810a4c02c9942d6aeb0a96b5d1acfa29",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b1a7c8b9_5b95cdbb",
"filename": "utilities/platform-util/debian/deb_folder/control",
"patchSetId": 6
},
"lineNbr": 31,
"author": {
"id": 28459
},
"writtenOn": "2021-10-11T18:47:11Z",
"side": 1,
"message": "nit: Simple Cleanup\n\n E: controller: description-starts-with-package-name",
"revId": "fb7c9edc810a4c02c9942d6aeb0a96b5d1acfa29",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6cab13ae_5598978b",
"filename": "utilities/platform-util/debian/deb_folder/control",
"patchSetId": 6
},
"lineNbr": 34,
"author": {
"id": 28459
},
"writtenOn": "2021-10-11T18:47:11Z",
"side": 1,
"message": "nit: Simple Cleanup\n\n E: controller: description-starts-with-package-name",
"revId": "fb7c9edc810a4c02c9942d6aeb0a96b5d1acfa29",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7c2e6063_ab991703",
"filename": "utilities/platform-util/debian/deb_folder/control",
"patchSetId": 6
},
"lineNbr": 39,
"author": {
"id": 28459
},
"writtenOn": "2021-10-11T18:47:11Z",
"side": 1,
"message": "Remove this line? Copy/paste error?",
"revId": "fb7c9edc810a4c02c9942d6aeb0a96b5d1acfa29",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9608c222_1d49fe31",
"filename": "utilities/platform-util/debian/deb_folder/rules",
"patchSetId": 6
},
"lineNbr": 4,
"author": {
"id": 28459
},
"writtenOn": "2021-10-11T18:47:11Z",
"side": 1,
"message": "Not used. Needed?",
"range": {
"startLine": 4,
"startChar": 0,
"endLine": 4,
"endChar": 15
},
"revId": "fb7c9edc810a4c02c9942d6aeb0a96b5d1acfa29",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ab48d446_ac3031c6",
"filename": "utilities/platform-util/debian/deb_folder/rules",
"patchSetId": 6
},
"lineNbr": 17,
"author": {
"id": 28459
},
"writtenOn": "2021-10-11T18:47:11Z",
"side": 1,
"message": "Wheels is empty because of misspelling. Should be: platform-util-wheel",
"range": {
"startLine": 17,
"startChar": 22,
"endLine": 17,
"endChar": 30
},
"revId": "fb7c9edc810a4c02c9942d6aeb0a96b5d1acfa29",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}