starlingx
/
utilities
Code Issues Proposed changes

Update patch set 63 

Patch Set 63:

(9 comments)

Patch-set: 63
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36339\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28464 \u003c28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36339\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 36339 \u003c36339@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36339\u003e replied on the change"}
This commit is contained in:
Gerrit User 36339 2023-11-29 19:27:14 +00:00 committed by Gerrit Code Review
parent 338e5c7e65
commit b17afd62e8
3 changed files with 184 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
69c810c2926dc36af651ee150b60d91469af2cee Normal file
View File

@ -0,0 +1,22 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "6859012b_ccfa2fb6",
"filename": "tools/collector/debian-scripts/report/render.py",
"patchSetId": 55
},
"lineNbr": 501,
"author": {
"id": 36339
},
"writtenOn": "2023-11-29T19:27:14Z",
"side": 1,
"message": "\u003e pep8: H404: multi line docstring should start without a leading new line\n\nPlease fix.",
"parentUuid": "63681532_2d74ef9a",
"revId": "69c810c2926dc36af651ee150b60d91469af2cee",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

84
a73715fc26b417a4d4bb603156a83f4e1b538483
View File

@ -23,6 +23,30 @@
"revId": "a73715fc26b417a4d4bb603156a83f4e1b538483",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "bf1815b0_cba23f9d",
"filename": "tools/collector/debian-scripts/report/render.py",
"patchSetId": 56
},
"lineNbr": 3,
"author": {
"id": 36339
},
"writtenOn": "2023-11-29T19:27:14Z",
"side": 1,
"message": "Done",
"parentUuid": "f2691630_bf81f12a",
"range": {
"startLine": 3,
"startChar": 16,
"endLine": 3,
"endChar": 27
},
"revId": "a73715fc26b417a4d4bb603156a83f4e1b538483",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +70,30 @@
"revId": "a73715fc26b417a4d4bb603156a83f4e1b538483",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1b2cce5e_f4dcf184",
"filename": "tools/collector/debian-scripts/report/render.py",
"patchSetId": 56
},
"lineNbr": 42,
"author": {
"id": 36339
},
"writtenOn": "2023-11-29T19:27:14Z",
"side": 1,
"message": "Done",
"parentUuid": "e92ccfa8_38728902",
"range": {
"startLine": 42,
"startChar": 28,
"endLine": 42,
"endChar": 32
},
"revId": "a73715fc26b417a4d4bb603156a83f4e1b538483",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -63,6 +111,24 @@
"revId": "a73715fc26b417a4d4bb603156a83f4e1b538483",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b66d907e_51933e0d",
"filename": "tools/collector/debian-scripts/report/render.py",
"patchSetId": 56
},
"lineNbr": 102,
"author": {
"id": 36339
},
"writtenOn": "2023-11-29T19:27:14Z",
"side": 1,
"message": "Done",
"parentUuid": "12a06f8d_66dcf184",
"revId": "a73715fc26b417a4d4bb603156a83f4e1b538483",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -79,6 +145,24 @@
"message": "approx how long does this step take and does it vary with size of bundle?",
"revId": "a73715fc26b417a4d4bb603156a83f4e1b538483",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "71893509_50619823",
"filename": "tools/collector/debian-scripts/report/report.py",
"patchSetId": 56
},
"lineNbr": 967,
"author": {
"id": 36339
},
"writtenOn": "2023-11-29T19:27:14Z",
"side": 1,
"message": "it takes immediately to generate and the size of the bundle doesn\u0027t affect the size of the index.html file (will be smaller than 30kb)",
"parentUuid": "a0030252_c426da31",
"revId": "a73715fc26b417a4d4bb603156a83f4e1b538483",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

78
c71aae7c58e800e28ddbfb2b0d28be224cc186eb
View File

@ -23,6 +23,30 @@
"revId": "c71aae7c58e800e28ddbfb2b0d28be224cc186eb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f2a7c456_e1a8f2fb",
"filename": "/COMMIT_MSG",
"patchSetId": 52
},
"lineNbr": 41,
"author": {
"id": 36339
},
"writtenOn": "2023-11-29T19:27:14Z",
"side": 1,
"message": "Done",
"parentUuid": "34b82d0c_0b043497",
"range": {
"startLine": 33,
"startChar": 0,
"endLine": 41,
"endChar": 79
},
"revId": "c71aae7c58e800e28ddbfb2b0d28be224cc186eb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -57,6 +81,24 @@
"revId": "c71aae7c58e800e28ddbfb2b0d28be224cc186eb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e4b32a7e_f7f3334b",
"filename": "tools/collector/debian-scripts/report/render.py",
"patchSetId": 52
},
"lineNbr": 1,
"author": {
"id": 36339
},
"writtenOn": "2023-11-29T19:27:14Z",
"side": 1,
"message": "Done",
"parentUuid": "71435fc0_bdd3c5fd",
"revId": "c71aae7c58e800e28ddbfb2b0d28be224cc186eb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -74,6 +116,24 @@
"revId": "c71aae7c58e800e28ddbfb2b0d28be224cc186eb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "299b4241_18eff7e2",
"filename": "tools/collector/debian-scripts/report/render.py",
"patchSetId": 52
},
"lineNbr": 5,
"author": {
"id": 36339
},
"writtenOn": "2023-11-29T19:27:14Z",
"side": 1,
"message": "Done",
"parentUuid": "bb18903f_3d2667ab",
"revId": "c71aae7c58e800e28ddbfb2b0d28be224cc186eb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -90,6 +150,24 @@
"message": "nit: suggest removing empty line.",
"revId": "c71aae7c58e800e28ddbfb2b0d28be224cc186eb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a0d43c33_f527b869",
"filename": "tools/collector/debian-scripts/report/render.py",
"patchSetId": 52
},
"lineNbr": 42,
"author": {
"id": 36339
},
"writtenOn": "2023-11-29T19:27:14Z",
"side": 1,
"message": "Done",
"parentUuid": "8e059526_8cbebe62",
"revId": "c71aae7c58e800e28ddbfb2b0d28be224cc186eb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}