starlingx
/
utilities
Code Issues Proposed changes

Enable a check in pylint for import-error 

The pci_irq_affinity files were using relative imports, so
this cleans up those imports and enables the E0401 import-error
pylint error code to be checked for all further commits.

Change-Id: I78de45bc6832e8bf252f6cd7134c283b10726a05
Story: 2004515
Task: 36667
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
This commit is contained in:
Al Bailey 2019-09-19 13:34:48 -05:00
parent 09f63f7cc9
commit d07c4a2910
8 changed files with 24 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pylint.rc
View File

@ -46,7 +46,6 @@ extension-pkg-whitelist=lxml.etree,greenlet
# We are disabling (R)efactor # We are disabling (R)efactor
# These error checks should be enabled whenever the code is cleaned up: # These error checks should be enabled whenever the code is cleaned up:
# E0203: access-member-before-definition # E0203: access-member-before-definition
# E0401: import-error
# E0611: no-name-in-module # E0611: no-name-in-module
# E1101: no-member # E1101: no-member
# E1135: unsupported-membership-test # E1135: unsupported-membership-test
@ -69,7 +68,7 @@ extension-pkg-whitelist=lxml.etree,greenlet
# W1202: logging-format-interpolation # W1202: logging-format-interpolation
# W1401: anomalous-backslash-in-string # W1401: anomalous-backslash-in-string
disable=C,R,fixme, disable=C,R,fixme,
E0203,E0401,E0611,E1101,E1135,E1205, E0203,E0611,E1101,E1135,E1205,
W0107,W0150,W0201,W0221,W0231,W0235,W0603,W0611,W0612,W0613,W0621,W0622, W0107,W0150,W0201,W0221,W0231,W0235,W0603,W0611,W0612,W0613,W0621,W0622,
W0702,W0703,W1201,W1202,W1401 W0702,W0703,W1201,W1202,W1401

8
utilities/pci-irq-affinity-agent/pci_irq_affinity/pci_irq_affinity/affinity.py
View File

@ -11,10 +11,10 @@
""" Define pci_irq_affinity_provider class""" """ Define pci_irq_affinity_provider class"""
import utils as pci_utils import pci_irq_affinity.utils as pci_utils
from driver import AffinePciIrqDriver from pci_irq_affinity.driver import AffinePciIrqDriver
from nova_provider import novaClient from pci_irq_affinity.nova_provider import novaClient
from log import LOG from pci_irq_affinity.log import LOG
class pci_irq_affinity_provider: class pci_irq_affinity_provider:

10
utilities/pci-irq-affinity-agent/pci_irq_affinity/pci_irq_affinity/agent.py
View File

@ -24,11 +24,11 @@ from oslo_service import periodic_task
from oslo_service import service from oslo_service import service
import oslo_messaging import oslo_messaging
from config import CONF from pci_irq_affinity.config import CONF
from config import sysconfig from pci_irq_affinity.config import sysconfig
from nova_provider import novaClient from pci_irq_affinity.nova_provider import novaClient
from affinity import pciIrqAffinity from pci_irq_affinity.affinity import pciIrqAffinity
from log import LOG from pci_irq_affinity.log import LOG
stay_on = True stay_on = True

10
utilities/pci-irq-affinity-agent/pci_irq_affinity/pci_irq_affinity/driver.py
View File

@ -13,11 +13,11 @@
from oslo_service import loopingcall from oslo_service import loopingcall
from oslo_concurrency import lockutils from oslo_concurrency import lockutils
import utils as pci_utils import pci_irq_affinity.utils as pci_utils
import instance import pci_irq_affinity.instance
from config import CONF from pci_irq_affinity.config import CONF
from log import LOG from pci_irq_affinity.log import LOG
from nova_provider import novaClient from pci_irq_affinity.nova_provider import novaClient
synchronized = lockutils.synchronized_with_prefix('pci_irq_affinity-') synchronized = lockutils.synchronized_with_prefix('pci_irq_affinity-')

2
utilities/pci-irq-affinity-agent/pci_irq_affinity/pci_irq_affinity/guest.py
View File

@ -17,7 +17,7 @@ import sys
import signal import signal
from xml.dom import minidom from xml.dom import minidom
from xml.etree import ElementTree from xml.etree import ElementTree
from log import LOG from pci_irq_affinity.log import LOG
debug = 0 debug = 0
# libvirt timeout parameters # libvirt timeout parameters

2
utilities/pci-irq-affinity-agent/pci_irq_affinity/pci_irq_affinity/instance.py
View File

@ -11,7 +11,7 @@
""" Define instance related class""" """ Define instance related class"""
from log import LOG from pci_irq_affinity.log import LOG
class numa_cell: class numa_cell:

10
utilities/pci-irq-affinity-agent/pci_irq_affinity/pci_irq_affinity/nova_provider.py
View File

@ -19,11 +19,11 @@ from novaclient import client
from keystoneauth1 import loading from keystoneauth1 import loading
from keystoneauth1 import session from keystoneauth1 import session
import socket import socket
from log import LOG from pci_irq_affinity.log import LOG
from config import CONF from pci_irq_affinity.config import CONF
from config import sysconfig from pci_irq_affinity.config import sysconfig
import instance from pci_irq_affinity import instance
import guest from pci_irq_affinity import guest
class NovaProvider: class NovaProvider:

4
utilities/pci-irq-affinity-agent/pci_irq_affinity/pci_irq_affinity/utils.py
View File

@ -15,8 +15,8 @@ import os
import errno import errno
from itertools import groupby from itertools import groupby
from log import LOG from pci_irq_affinity.log import LOG
import instance import pci_irq_affinity.instance
def list_to_range(input_list=None): def list_to_range(input_list=None):