starlingx
/
utilities
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(1 comment)

Patch-set: 1
This commit is contained in:
Gerrit User 28747 2019-09-11 08:42:20 +00:00 committed by Gerrit Code Review
parent cf6f71df97
commit f6057b1d0f
1 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
ed1ba1665059f19c91a3463cd0366f6c016fd51d Normal file
View File

@ -0,0 +1,27 @@
{
"comments": [
{
"key": {
"uuid": "5faad753_54c21eeb",
"filename": "ceph/ceph-manager/ceph-manager/ceph_manager/monitor.py",
"patchSetId": 1
},
"lineNbr": 230,
"author": {
"id": 28747
},
"writtenOn": "2019-09-11T08:42:20Z",
"side": 0,
"message": "My proposal is to keep cleat_all_major_critical(), but only run its code if we know for sure that there is no OSD alarm raised. The idea is to have a fail safe that clears stale alarms (i.e. in case of process restart).\n\nSo, in _report_alarm_osds_health() add a self._osd_down_alarm toggle then here keep the call to clear_all_major_critical if health is CEPH_HEALTH_OK and self._osd_down_alarm is false.",
"range": {
"startLine": 229,
"startChar": 0,
"endLine": 230,
"endChar": 43
},
"revId": "ed1ba1665059f19c91a3463cd0366f6c016fd51d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}