Update patch set 6
Patch Set 6: (3 comments) Patch-set: 6 Attention: {"person_ident":"Gerrit User 33549 \u003c33549@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33549\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 34119 \u003c34119@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33549\u003e replied on the change"}
This commit is contained in:
parent
ebc2191861
commit
fd96ee3523
|
@ -0,0 +1,73 @@
|
||||||
|
{
|
||||||
|
"comments": [
|
||||||
|
{
|
||||||
|
"unresolved": true,
|
||||||
|
"key": {
|
||||||
|
"uuid": "37f566e6_6ad02eea",
|
||||||
|
"filename": "/COMMIT_MSG",
|
||||||
|
"patchSetId": 6
|
||||||
|
},
|
||||||
|
"lineNbr": 25,
|
||||||
|
"author": {
|
||||||
|
"id": 33549
|
||||||
|
},
|
||||||
|
"writtenOn": "2022-11-07T23:10:54Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Just need a space here - this link is broken",
|
||||||
|
"range": {
|
||||||
|
"startLine": 25,
|
||||||
|
"startChar": 0,
|
||||||
|
"endLine": 25,
|
||||||
|
"endChar": 13
|
||||||
|
},
|
||||||
|
"revId": "bf8d1ab241997c9290e02116638d45f8575d487d",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"unresolved": true,
|
||||||
|
"key": {
|
||||||
|
"uuid": "f510b428_a7360361",
|
||||||
|
"filename": "utilities/platform-util/scripts/gen-prestaged-iso.sh",
|
||||||
|
"patchSetId": 6
|
||||||
|
},
|
||||||
|
"lineNbr": 176,
|
||||||
|
"author": {
|
||||||
|
"id": 33549
|
||||||
|
},
|
||||||
|
"writtenOn": "2022-11-07T23:10:54Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "This is empty here, is this correct/expected?\n\nI\u0027m trying to figure out why the normalized_path function is necessary here. I admit I\u0027m not really sure what it\u0027s doing in this case.",
|
||||||
|
"range": {
|
||||||
|
"startLine": 176,
|
||||||
|
"startChar": 40,
|
||||||
|
"endLine": 176,
|
||||||
|
"endChar": 54
|
||||||
|
},
|
||||||
|
"revId": "bf8d1ab241997c9290e02116638d45f8575d487d",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"unresolved": true,
|
||||||
|
"key": {
|
||||||
|
"uuid": "4e1fd13f_2f892be5",
|
||||||
|
"filename": "utilities/platform-util/scripts/gen-prestaged-iso.sh",
|
||||||
|
"patchSetId": 6
|
||||||
|
},
|
||||||
|
"lineNbr": 178,
|
||||||
|
"author": {
|
||||||
|
"id": 33549
|
||||||
|
},
|
||||||
|
"writtenOn": "2022-11-07T23:10:54Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "I\u0027m not sure this directory is ever used? Can it be removed (and also the check on line 193)?",
|
||||||
|
"range": {
|
||||||
|
"startLine": 178,
|
||||||
|
"startChar": 8,
|
||||||
|
"endLine": 178,
|
||||||
|
"endChar": 21
|
||||||
|
},
|
||||||
|
"revId": "bf8d1ab241997c9290e02116638d45f8575d487d",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
Loading…
Reference in New Issue