utilities/bf8d1ab241997c9290e02116638...

169 lines
4.8 KiB
Plaintext

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "37f566e6_6ad02eea",
"filename": "/COMMIT_MSG",
"patchSetId": 6
},
"lineNbr": 25,
"author": {
"id": 33549
},
"writtenOn": "2022-11-07T23:10:54Z",
"side": 1,
"message": "Just need a space here - this link is broken",
"range": {
"startLine": 25,
"startChar": 0,
"endLine": 25,
"endChar": 13
},
"revId": "bf8d1ab241997c9290e02116638d45f8575d487d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8341769b_b23b54fc",
"filename": "/COMMIT_MSG",
"patchSetId": 6
},
"lineNbr": 25,
"author": {
"id": 34119
},
"writtenOn": "2022-11-08T01:53:00Z",
"side": 1,
"message": "Done",
"parentUuid": "37f566e6_6ad02eea",
"range": {
"startLine": 25,
"startChar": 0,
"endLine": 25,
"endChar": 13
},
"revId": "bf8d1ab241997c9290e02116638d45f8575d487d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f510b428_a7360361",
"filename": "utilities/platform-util/scripts/gen-prestaged-iso.sh",
"patchSetId": 6
},
"lineNbr": 176,
"author": {
"id": 33549
},
"writtenOn": "2022-11-07T23:10:54Z",
"side": 1,
"message": "This is empty here, is this correct/expected?\n\nI\u0027m trying to figure out why the normalized_path function is necessary here. I admit I\u0027m not really sure what it\u0027s doing in this case.",
"range": {
"startLine": 176,
"startChar": 40,
"endLine": 176,
"endChar": 54
},
"revId": "bf8d1ab241997c9290e02116638d45f8575d487d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "33637ec1_713c3cfd",
"filename": "utilities/platform-util/scripts/gen-prestaged-iso.sh",
"patchSetId": 6
},
"lineNbr": 176,
"author": {
"id": 34119
},
"writtenOn": "2022-11-08T01:53:00Z",
"side": 1,
"message": "This is legacy code. In this particular case, normalized_path really is doing nothing. removing.",
"parentUuid": "f510b428_a7360361",
"range": {
"startLine": 176,
"startChar": 40,
"endLine": 176,
"endChar": 54
},
"revId": "bf8d1ab241997c9290e02116638d45f8575d487d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4e1fd13f_2f892be5",
"filename": "utilities/platform-util/scripts/gen-prestaged-iso.sh",
"patchSetId": 6
},
"lineNbr": 178,
"author": {
"id": 33549
},
"writtenOn": "2022-11-07T23:10:54Z",
"side": 1,
"message": "I\u0027m not sure this directory is ever used? Can it be removed (and also the check on line 193)?",
"range": {
"startLine": 178,
"startChar": 8,
"endLine": 178,
"endChar": 21
},
"revId": "bf8d1ab241997c9290e02116638d45f8575d487d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "87bd6898_8ec3fe9d",
"filename": "utilities/platform-util/scripts/gen-prestaged-iso.sh",
"patchSetId": 6
},
"lineNbr": 178,
"author": {
"id": 34119
},
"writtenOn": "2022-11-08T01:53:00Z",
"side": 1,
"message": "It is used in line 207. This code is reused code from the centos prestage code. \nThe purpose of this code is to copy the md5 sum where required (like container images). Prefer to keep it, to avoid reinventing the code.",
"parentUuid": "4e1fd13f_2f892be5",
"range": {
"startLine": 178,
"startChar": 8,
"endLine": 178,
"endChar": 21
},
"revId": "bf8d1ab241997c9290e02116638d45f8575d487d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7723ec33_c215908c",
"filename": "utilities/platform-util/scripts/gen-prestaged-iso.sh",
"patchSetId": 6
},
"lineNbr": 178,
"author": {
"id": 33549
},
"writtenOn": "2022-11-08T15:37:05Z",
"side": 1,
"message": "Look again, I don\u0027t see final_md5_dir on line 207.",
"parentUuid": "87bd6898_8ec3fe9d",
"range": {
"startLine": 178,
"startChar": 8,
"endLine": 178,
"endChar": 21
},
"revId": "bf8d1ab241997c9290e02116638d45f8575d487d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}