161 lines
5.4 KiB
Plaintext
161 lines
5.4 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "cb73688b_18dad9e8",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 28652
|
|
},
|
|
"writtenOn": "2022-10-25T21:59:07Z",
|
|
"side": 1,
|
|
"message": "Also put your full name in your account settings here on opendev",
|
|
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "de2278a8_c3e041b4",
|
|
"filename": "tools/opae/opae-sdk/debian/deb_folder/opae-devel.install",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 4,
|
|
"author": {
|
|
"id": 28652
|
|
},
|
|
"writtenOn": "2022-10-25T21:59:07Z",
|
|
"side": 1,
|
|
"message": "Do the above commands need to be run as root? If so, usr/sbin makes more sense.",
|
|
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "666db0bc_921bb3c9",
|
|
"filename": "tools/opae/opae-sdk/debian/deb_folder/opae-devel.install",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 4,
|
|
"author": {
|
|
"id": 33136
|
|
},
|
|
"writtenOn": "2022-10-26T13:12:27Z",
|
|
"side": 1,
|
|
"message": "Are you sure that we need sudo? I dont see that in the OPAE documentaion.\nThe files are located at the same path as for CentOS.\nThe Debian packages are equivalent to the RPM packages in this sense.",
|
|
"parentUuid": "de2278a8_c3e041b4",
|
|
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "cf815d26_c4bd8690",
|
|
"filename": "tools/opae/opae-sdk/debian/deb_folder/opae-tools-extra.install",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 27,
|
|
"author": {
|
|
"id": 28652
|
|
},
|
|
"writtenOn": "2022-10-25T21:59:07Z",
|
|
"side": 1,
|
|
"message": "Do the above commands need to be run as root? If so, usr/sbin makes more sense.",
|
|
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "bb755bf0_6be31546",
|
|
"filename": "tools/opae/opae-sdk/debian/deb_folder/opae-tools-extra.install",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 27,
|
|
"author": {
|
|
"id": 33136
|
|
},
|
|
"writtenOn": "2022-10-26T13:12:27Z",
|
|
"side": 1,
|
|
"message": "Are you sure that we need sudo? I dont see that in the OPAE documentaion.\nThe files are located at the same path as for CentOS.\nThe Debian packages are equivalent to the RPM packages in this sense.",
|
|
"parentUuid": "cf815d26_c4bd8690",
|
|
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ef07f105_39213ac3",
|
|
"filename": "tools/opae/opae-sdk/debian/deb_folder/opae-tools.install",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 5,
|
|
"author": {
|
|
"id": 28652
|
|
},
|
|
"writtenOn": "2022-10-25T21:59:07Z",
|
|
"side": 1,
|
|
"message": "Do the above commands need to be run as root? If so, usr/sbin makes more sense.",
|
|
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "682e7644_fa16c61d",
|
|
"filename": "tools/opae/opae-sdk/debian/deb_folder/opae-tools.install",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 5,
|
|
"author": {
|
|
"id": 33136
|
|
},
|
|
"writtenOn": "2022-10-26T13:12:27Z",
|
|
"side": 1,
|
|
"message": "Are you sure that we need sudo? I dont see that in the OPAE documentaion.\nThe files are located at the same path as for CentOS.\nThe Debian packages are equivalent to the RPM packages in this sense.",
|
|
"parentUuid": "ef07f105_39213ac3",
|
|
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ee543466_3a45114f",
|
|
"filename": "tools/opae/python3-opae.admin/debian/dl_hook",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 30,
|
|
"author": {
|
|
"id": 28652
|
|
},
|
|
"writtenOn": "2022-10-25T21:59:07Z",
|
|
"side": 1,
|
|
"message": "This makes me very uneasy. We\u0027re writing their license file for them? Are you sure there isn\u0027t a license somewhere governing this?",
|
|
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "91f7ac4a_41fd21c5",
|
|
"filename": "tools/opae/python3-opae.admin/debian/dl_hook",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 30,
|
|
"author": {
|
|
"id": 33136
|
|
},
|
|
"writtenOn": "2022-10-26T13:12:27Z",
|
|
"side": 1,
|
|
"message": "The contents are identical to the license provided in the OPAE ZIP file.\nNext commit I will extract it from the ZIP file instead.",
|
|
"parentUuid": "ee543466_3a45114f",
|
|
"revId": "2c448a3d663945b3bcfcdc8f909e0c35f0cf9089",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |