591459a79a
Patch Set 2: (3 comments) Patch-set: 2 Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 35286 \u003c35286@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
55 lines
1.7 KiB
Plaintext
55 lines
1.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "691ea6b8_9416af7d",
|
|
"filename": "tools/collector/debian-scripts/collect",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 3089,
|
|
"author": {
|
|
"id": 9926
|
|
},
|
|
"writtenOn": "2022-12-02T15:09:19Z",
|
|
"side": 1,
|
|
"message": "should check result of previous operation before proceeding with \u0027rm ...\u0027 operation",
|
|
"revId": "0cdb076ed53d39f672bee7bbde6fac68dada3a6a",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4b95669e_e86a4ec0",
|
|
"filename": "tools/collector/report/correlator.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 255,
|
|
"author": {
|
|
"id": 9926
|
|
},
|
|
"writtenOn": "2022-12-02T15:09:19Z",
|
|
"side": 1,
|
|
"message": "nit: should split up long lines \u003e 79 chars (though tox isnt currently enforcing)",
|
|
"revId": "0cdb076ed53d39f672bee7bbde6fac68dada3a6a",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "3848476c_e0131f4d",
|
|
"filename": "tools/collector/report/correlator.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 412,
|
|
"author": {
|
|
"id": 9926
|
|
},
|
|
"writtenOn": "2022-12-02T15:09:19Z",
|
|
"side": 1,
|
|
"message": "Is there a limitation with \u0027with open() as ...: \u0027 that prevents its use here? \ni.e. https://www.geeksforgeeks.org/with-statement-in-python/",
|
|
"revId": "0cdb076ed53d39f672bee7bbde6fac68dada3a6a",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |