utilities/2083c8a320795e62fcdd9fb9acbbd2c8e6b82848

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "d2d94be7_16b45523",
        "filename": "/COMMIT_MSG",
        "patchSetId": 3
      },
      "lineNbr": 9,
      "author": {
        "id": 32870
      },
      "writtenOn": "2022-10-18T15:32:08Z",
      "side": 1,
      "message": "The commit messages only mentions that the OPAE tools are introduces in the container image, however, this also actually introduces the OPAE packages separately, so it should be also described in the commit message.",
      "revId": "2083c8a320795e62fcdd9fb9acbbd2c8e6b82848",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "2ea28d70_c3c87014",
        "filename": "/COMMIT_MSG",
        "patchSetId": 3
      },
      "lineNbr": 9,
      "author": {
        "id": 33136
      },
      "writtenOn": "2022-10-18T18:04:50Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "d2d94be7_16b45523",
      "revId": "2083c8a320795e62fcdd9fb9acbbd2c8e6b82848",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "ced56547_d4754b15",
        "filename": "debian_pkg_dirs",
        "patchSetId": 3
      },
      "lineNbr": 6,
      "author": {
        "id": 32870
      },
      "writtenOn": "2022-10-18T15:37:03Z",
      "side": 1,
      "message": "Using \".\" instead of \"-\" as separator seem to be breaking the pattern used, opae-admin, and opae-pacsign seem to be more suitable.\nIf changing, need to change the folder names too.",
      "revId": "2083c8a320795e62fcdd9fb9acbbd2c8e6b82848",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "1742dbdd_6bbe7875",
        "filename": "debian_pkg_dirs",
        "patchSetId": 3
      },
      "lineNbr": 6,
      "author": {
        "id": 33136
      },
      "writtenOn": "2022-10-18T18:07:02Z",
      "side": 1,
      "message": "Adriano, these are the official names as per OPAE tools\u0027 documentation.\nI tested that it does not cause any harm",
      "parentUuid": "ced56547_d4754b15",
      "revId": "2083c8a320795e62fcdd9fb9acbbd2c8e6b82848",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "2403585f_573a88ad",
        "filename": "debian_pkg_dirs",
        "patchSetId": 3
      },
      "lineNbr": 6,
      "author": {
        "id": 32870
      },
      "writtenOn": "2022-10-18T23:55:17Z",
      "side": 1,
      "message": "Ok, I haven\u0027t seen that naming pattern comes from the original package itself, however, it is \"python3-*\" shouldn\u0027t we follow the same pattern on the packages name, and have the folders as python3-opae.admin and python3-opae.pacsing?",
      "parentUuid": "1742dbdd_6bbe7875",
      "revId": "2083c8a320795e62fcdd9fb9acbbd2c8e6b82848",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "d4187398_6a957da9",
        "filename": "debian_pkg_dirs",
        "patchSetId": 3
      },
      "lineNbr": 6,
      "author": {
        "id": 33136
      },
      "writtenOn": "2022-10-19T13:42:02Z",
      "side": 1,
      "message": "The folder names follows the *source code* names given by the OPAE developers. The \"python3-\" prefix is given for the Debian package, in accordance with Python naming conventions for Debian.",
      "parentUuid": "2403585f_573a88ad",
      "revId": "2083c8a320795e62fcdd9fb9acbbd2c8e6b82848",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "bebd810d_6c0493ab",
        "filename": "tools/opae/opae.admin/debian/deb_folder/control",
        "patchSetId": 3
      },
      "lineNbr": 18,
      "author": {
        "id": 32870
      },
      "writtenOn": "2022-10-18T15:32:08Z",
      "side": 1,
      "message": "Isn\u0027t this package depending on any other OPAE package included? If so, should be included as depends here.",
      "revId": "2083c8a320795e62fcdd9fb9acbbd2c8e6b82848",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "5181471e_f0bfbcd5",
        "filename": "tools/opae/opae.admin/debian/deb_folder/control",
        "patchSetId": 3
      },
      "lineNbr": 18,
      "author": {
        "id": 33136
      },
      "writtenOn": "2022-10-18T18:04:50Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "bebd810d_6c0493ab",
      "revId": "2083c8a320795e62fcdd9fb9acbbd2c8e6b82848",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "ad2301ee_3713e440",
        "filename": "tools/opae/opae.pacsign/debian/deb_folder/control",
        "patchSetId": 3
      },
      "lineNbr": 17,
      "author": {
        "id": 32870
      },
      "writtenOn": "2022-10-18T15:32:08Z",
      "side": 1,
      "message": "Not depending on other opae packages?",
      "revId": "2083c8a320795e62fcdd9fb9acbbd2c8e6b82848",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "44a32c0f_e63967bf",
        "filename": "tools/opae/opae.pacsign/debian/deb_folder/control",
        "patchSetId": 3
      },
      "lineNbr": 17,
      "author": {
        "id": 33136
      },
      "writtenOn": "2022-10-18T18:04:50Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "ad2301ee_3713e440",
      "revId": "2083c8a320795e62fcdd9fb9acbbd2c8e6b82848",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}