72 lines
2.3 KiB
Plaintext
72 lines
2.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d2d94be7_16b45523",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 9,
|
|
"author": {
|
|
"id": 32870
|
|
},
|
|
"writtenOn": "2022-10-18T15:32:08Z",
|
|
"side": 1,
|
|
"message": "The commit messages only mentions that the OPAE tools are introduces in the container image, however, this also actually introduces the OPAE packages separately, so it should be also described in the commit message.",
|
|
"revId": "2083c8a320795e62fcdd9fb9acbbd2c8e6b82848",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ced56547_d4754b15",
|
|
"filename": "debian_pkg_dirs",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 6,
|
|
"author": {
|
|
"id": 32870
|
|
},
|
|
"writtenOn": "2022-10-18T15:37:03Z",
|
|
"side": 1,
|
|
"message": "Using \".\" instead of \"-\" as separator seem to be breaking the pattern used, opae-admin, and opae-pacsign seem to be more suitable.\nIf changing, need to change the folder names too.",
|
|
"revId": "2083c8a320795e62fcdd9fb9acbbd2c8e6b82848",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "bebd810d_6c0493ab",
|
|
"filename": "tools/opae/opae.admin/debian/deb_folder/control",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 18,
|
|
"author": {
|
|
"id": 32870
|
|
},
|
|
"writtenOn": "2022-10-18T15:32:08Z",
|
|
"side": 1,
|
|
"message": "Isn\u0027t this package depending on any other OPAE package included? If so, should be included as depends here.",
|
|
"revId": "2083c8a320795e62fcdd9fb9acbbd2c8e6b82848",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ad2301ee_3713e440",
|
|
"filename": "tools/opae/opae.pacsign/debian/deb_folder/control",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 17,
|
|
"author": {
|
|
"id": 32870
|
|
},
|
|
"writtenOn": "2022-10-18T15:32:08Z",
|
|
"side": 1,
|
|
"message": "Not depending on other opae packages?",
|
|
"revId": "2083c8a320795e62fcdd9fb9acbbd2c8e6b82848",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |