103 lines
7.7 KiB
Plaintext
103 lines
7.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f8403656_63b53bce",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 15435
|
|
},
|
|
"writtenOn": "2022-11-02T18:13:25Z",
|
|
"side": 1,
|
|
"message": "Shellcheck shows the following for these new lines.\nNone of these issues look serious (to me) but I am including the shellcheck output here in case another core thinks it should be resolved\n\nIn scripts/gen-prestaged-iso.sh line 103:\n if [ $? -ne 0 ]; then\n ^-- SC2181: Check exit code directly with e.g. \u0027if mycmd;\u0027, not indirectly with $?.\n\n\nIn scripts/gen-prestaged-iso.sh line 113:\n local path_name\u003d\"$(basename \"${path}\")\"\n ^-------^ SC2155: Declare and assign separately to avoid masking return values.\n\n\nIn scripts/gen-prestaged-iso.sh line 114:\n local path_dir\u003d\"$(dirname \"${path}\")\"\n ^------^ SC2155: Declare and assign separately to avoid masking return values.\n\n\nIn scripts/gen-prestaged-iso.sh line 168:\n if [ ! -z \"${md5}\" ]; then\n ^-- SC2236: Use -n instead of ! -z.\n\n\nIn scripts/gen-prestaged-iso.sh line 169:\n default_md5\u003d\"$(basename \"${dest}.md5\")\"\n ^---------^ SC2034: default_md5 appears unused. Verify use (or export if used externally).\n\n\nIn scripts/gen-prestaged-iso.sh line 195:\n if [ ! -z \"${final_md5_dir}\" ]; then\n ^-- SC2236: Use -n instead of ! -z.\n\n\nIn scripts/gen-prestaged-iso.sh line 203:\n if [ $? -ne 0 ]; then\n ^-- SC2181: Check exit code directly with e.g. \u0027if mycmd;\u0027, not indirectly with $?.\n\n\nIn scripts/gen-prestaged-iso.sh line 208:\n if [ ! -z \"${final_md5}\" ]; then\n ^-- SC2236: Use -n instead of ! -z.\n\n\nIn scripts/gen-prestaged-iso.sh line 209:\n pushd ${final_dest_dir} \u003e /dev/null\n ^-- SC2164: Use \u0027pushd ... || exit\u0027 or \u0027pushd ... || return\u0027 in case pushd fails.\n ^---------------^ SC2086: Double quote to prevent globbing and word splitting.\n\nDid you mean:\n pushd \"${final_dest_dir}\" \u003e /dev/null || exit\n\n\nIn scripts/gen-prestaged-iso.sh line 211:\n popd \u003e /dev/null\n ^--------------^ SC2164: Use \u0027popd ... || exit\u0027 or \u0027popd ... || return\u0027 in case popd fails.\n\nDid you mean:\n popd \u003e /dev/null || exit\n\n\n\n\nIn scripts/gen-prestaged-iso.sh line 455:\ncheck_files_exist ${INPUT_ISO} ${PATCHES[@]} ${IMAGES[@]} ${KS_SETUP} ${KS_ADDON}\n ^----------^ SC2086: Double quote to prevent globbing and word splitting.\n ^-----------^ SC2068: Double quote array expansions to avoid re-splitting elements.\n ^----------^ SC2068: Double quote array expansions to avoid re-splitting elements.\n ^---------^ SC2086: Double quote to prevent globbing and word splitting.\n ^---------^ SC2086: Double quote to prevent globbing and word splitting.\n\nDid you mean:\ncheck_files_exist \"${INPUT_ISO}\" ${PATCHES[@]} ${IMAGES[@]} \"${KS_SETUP}\" \"${KS_ADDON}\"\n\n\nIn scripts/gen-prestaged-iso.sh line 456:\ncheck_files_size ${INPUT_ISO} ${PATCHES[@]} ${IMAGES[@]} ${KS_SETUP} ${KS_ADDON}\n ^----------^ SC2086: Double quote to prevent globbing and word splitting.\n ^-----------^ SC2068: Double quote array expansions to avoid re-splitting elements.\n ^----------^ SC2068: Double quote array expansions to avoid re-splitting elements.\n ^---------^ SC2086: Double quote to prevent globbing and word splitting.\n ^---------^ SC2086: Double quote to prevent globbing and word splitting.\n\nDid you mean:\ncheck_files_size \"${INPUT_ISO}\" ${PATCHES[@]} ${IMAGES[@]} \"${KS_SETUP}\" \"${KS_ADDON}\"\n\n\nIn scripts/gen-prestaged-iso.sh line 476:\nif [ ! -f ${MNTDIR}/upgrades/version ]; then\n ^-------^ SC2086: Double quote to prevent globbing and word splitting.\n\nDid you mean:\nif [ ! -f \"${MNTDIR}\"/upgrades/version ]; then\n\n\nIn scripts/gen-prestaged-iso.sh line 481:\nISO_VERSION\u003d$(source ${MNTDIR}/upgrades/version \u0026\u0026 echo ${VERSION})\n ^------------------------^ SC1090: Can\u0027t follow non-constant source. Use a directive to specify location.\n ^-------^ SC2086: Double quote to prevent globbing and word splitting.\n ^--------^ SC2086: Double quote to prevent globbing and word splitting.\nDid you mean:\nISO_VERSION\u003d$(source \"${MNTDIR}\"/upgrades/version \u0026\u0026 echo \"${VERSION}\")\n\n\nIn scripts/gen-prestaged-iso.sh line 508:\nfor PATCH in ${PATCHES[@]}; do\n ^-----------^ SC2068: Double quote array expansions to avoid re-splitting elements.\n\n\nIn scripts/gen-prestaged-iso.sh line 512:\nfor IMAGE in ${IMAGES[@]}; do\n ^----------^ SC2068: Double quote array expansions to avoid re-splitting elements.\n\n\n\n",
|
|
"revId": "78ae45a674ceb734e9aa0067d53e7565c91dcee7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e8a534a2_38a99522",
|
|
"filename": "utilities/platform-util/scripts/gen-prestaged-iso.sh",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 169,
|
|
"author": {
|
|
"id": 15435
|
|
},
|
|
"writtenOn": "2022-11-02T18:17:00Z",
|
|
"side": 1,
|
|
"message": "shellcheck indicates that nothing uses this \u0027default_md5\u0027",
|
|
"revId": "78ae45a674ceb734e9aa0067d53e7565c91dcee7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "11e48f98_ac312004",
|
|
"filename": "utilities/platform-util/scripts/gen-prestaged-iso.sh",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 169,
|
|
"author": {
|
|
"id": 34119
|
|
},
|
|
"writtenOn": "2022-11-03T18:58:25Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "e8a534a2_38a99522",
|
|
"revId": "78ae45a674ceb734e9aa0067d53e7565c91dcee7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "84eea13f_6cc0be6d",
|
|
"filename": "utilities/platform-util/scripts/gen-prestaged-iso.sh",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 202,
|
|
"author": {
|
|
"id": 33549
|
|
},
|
|
"writtenOn": "2022-11-04T19:57:56Z",
|
|
"side": 1,
|
|
"message": "Normally you might use an escape like this to avoid using an alias, but this isn\u0027t needed in a script.",
|
|
"range": {
|
|
"startLine": 202,
|
|
"startChar": 4,
|
|
"endLine": 202,
|
|
"endChar": 5
|
|
},
|
|
"revId": "78ae45a674ceb734e9aa0067d53e7565c91dcee7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "26d9d6c2_b603ebc7",
|
|
"filename": "utilities/platform-util/scripts/gen-prestaged-iso.sh",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 202,
|
|
"author": {
|
|
"id": 34119
|
|
},
|
|
"writtenOn": "2022-11-07T18:06:48Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "84eea13f_6cc0be6d",
|
|
"range": {
|
|
"startLine": 202,
|
|
"startChar": 4,
|
|
"endLine": 202,
|
|
"endChar": 5
|
|
},
|
|
"revId": "78ae45a674ceb734e9aa0067d53e7565c91dcee7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |