starlingx
/
virtual-deployment
Code Issues Proposed changes

libvirt: fix readconfig.sh usage and permissions 

readconfig.sh intends to export variables to the current shell, and
should be sourced using the 'source' command.  It is ineffective when
run as a sub-process.

Fix the file permission, since the script should be sourced rather than
executed.

Test Plan:
PASS: regression of default and madcloud examples
PASS: documented usage is effective

Story: 2010816
Task: 48614

Change-Id: I7e35ccf253e27b8209f8bf17dca065c58b016e14
Signed-off-by: Michel Thebeau <michel.thebeau@windriver.com>
This commit is contained in:
Michel Thebeau 2023-08-14 15:20:27 -04:00
parent 14279bfcba
commit 43de3e6910
2 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libvirt/README.rst
View File

@ -28,7 +28,7 @@ an interactive shell that configures everything. Here's an example::
export EXTERNAL_NETWORK=172.30.20.0/24
export EXTERNAL_IP=172.30.20.1/24
Using ``./readconfig.sh madcloud.yaml`` also sets the madcloud
Using ``source ./readconfig.sh madcloud.yaml`` also sets the madcloud
environment variables. Use ``default.yaml`` or ``madcloud.yaml`` as
templates to make custom configurations.

0
libvirt/readconfig.sh Executable file → Normal file
View File