From 074cb35e2990b8d36fadfb3cceac7087e01501f3 Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Sun, 12 Apr 2015 17:03:24 -0400 Subject: [PATCH] Don't display draft approvals in change list A draft approval (eg, saved by gertty when someone cancels a review) would be displayed in the change list entry for a change when it should not. This corrects that. Change-Id: I78364245197a6fbe2532b0d588c5002fe4975012 --- gertty/db.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gertty/db.py b/gertty/db.py index 8547b93..5396644 100644 --- a/gertty/db.py +++ b/gertty/db.py @@ -231,6 +231,8 @@ class Change(object): cat_max = {} cat_value = {} for approval in self.approvals: + if approval.draft: + continue cur_min = cat_min.get(approval.category, 0) cur_max = cat_max.get(approval.category, 0) cur_min = min(approval.value, cur_min)