From 31af7ed1823706649fba28b7f0b263a9826f15a7 Mon Sep 17 00:00:00 2001 From: James Polley Date: Thu, 2 Jul 2015 12:08:43 +1000 Subject: [PATCH] Show all held changes in held-changes view I commented on a review while offline yesterday. When I came online, someone had provided a -2. Being a more-negative comment than mine, this held my change, and added a warning in the top-right to tell me I had a held change. However, I couldn't *see* the held change in held-changes view, because it only shows me open changes - and this particular change was abandoned after the -2. This change makes held-changes view show all held changes,not just open held changes. An alternative here might be to not warn the user about held changes if they have been abandoned; but that could be confusing if my comment had been "I think this shouldn't be abandoned because".... Change-Id: I5165f50af30b51ae29f2639dd5fd4185b02aa1fa --- gertty/app.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gertty/app.py b/gertty/app.py index 9c91577..9e9a38f 100644 --- a/gertty/app.py +++ b/gertty/app.py @@ -516,7 +516,7 @@ class App(object): elif keymap.CHANGE_SEARCH in commands: self.searchDialog() elif keymap.LIST_HELD in commands: - self.doSearch("status:open is:held") + self.doSearch("is:held") elif key in self.config.dashboards: d = self.config.dashboards[key] view = view_change_list.ChangeListView(self, d['query'], d['name'])