ttygroup
/
boartty
Code Issues Proposed changes

Fix error in double upload 

If more than one uploadreviewtask is submitted for a message, the
message will not exist for the second or later task.  In that case,
do not throw a traceback into the log.

Change-Id: I53bc0ff2b9e0bbdea5eeaa823a438cd48d337fa4
This commit is contained in:
James E. Blair 2015-04-07 14:24:47 -07:00
parent dfff0e8fc3
commit b16a60d383
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gertty/sync.py
View File

@ -930,6 +930,10 @@ class UploadReviewTask(Task):
with app.db.getSession() as session:
message = session.getMessage(self.message_key)
if message is None:
self.log.debug("Message %s for change %s has already been uploaded" % (
self.message_key, change.id))
return
change = message.revision.change
if not change.held:
self.log.debug("Syncing %s to find out if it should be held" % (change.id,))