From 913818beb63a97e1b1752c19f4f97451cd7696ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Andr=C3=A9?= Date: Mon, 27 Jun 2016 16:54:07 +0200 Subject: [PATCH] Display gate results ordered The OrderedDict type returned by `commentlink.getTestResults()` was lost when being passed to `_updateTestResults()`. This commit restores the order as it is supposed to be. Change-Id: Ie7fc7afd54a0243e4fe956b32061e98d743f7245 --- gertty/view/change.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/gertty/view/change.py b/gertty/view/change.py index d90aaf2..95677ee 100644 --- a/gertty/view/change.py +++ b/gertty/view/change.py @@ -13,8 +13,13 @@ # License for the specific language governing permissions and limitations # under the License. +import collections import datetime import logging +try: + import ordereddict +except: + pass import textwrap from six.moves.urllib import parse as urlparse @@ -29,6 +34,11 @@ from gertty.view import unified_diff as view_unified_diff from gertty.view import mouse_scroll_decorator import gertty.view +try: + OrderedDict = collections.OrderedDict +except AttributeError: + OrderedDict = ordereddict.OrderedDict + class EditTopicDialog(mywid.ButtonDialog): signals = ['save', 'cancel'] def __init__(self, app, topic): @@ -733,7 +743,8 @@ class ChangeView(urwid.WidgetWrap): for commentlink in self.app.config.commentlinks: results = commentlink.getTestResults(self.app, message.message) if results: - result_system = result_systems.get(message.author.name, {}) + result_system = result_systems.get(message.author.name, + OrderedDict()) result_systems[message.author.name] = result_system result_system.update(results) skip = False