From c9f094a62f8141d56282e476ea00624beb12c328 Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Sat, 17 May 2014 18:36:02 -0400 Subject: [PATCH] Change review toggle keybinding to 'v'. So that the review toggle command can have the same keybinding in the change list and change view, switch it to 'v'. 'r' and 'd' are other candidates but both make more sense for the 'review' and 'diff' commands in the change view. Change-Id: I806fd528cc6fa648450d69181aadbacd67548dda --- gertty/view/change.py | 4 ++-- gertty/view/change_list.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gertty/view/change.py b/gertty/view/change.py index 348730f..8d1bb8a 100644 --- a/gertty/view/change.py +++ b/gertty/view/change.py @@ -260,10 +260,10 @@ class ChangeView(urwid.WidgetWrap): help = mywid.GLOBAL_HELP + """ This Screen =========== - Toggle the reviewed flag for the current change. Checkout the most recent revision. Show the diff of the mont recent revision. Leave a review for the most recent revision. + Toggle the reviewed flag for the current change. """ def __init__(self, app, change_key): @@ -420,7 +420,7 @@ This Screen def keypress(self, size, key): r = super(ChangeView, self).keypress(size, key) - if r == 'R': + if r == 'v': self.toggleReviewed() self.refresh() return None diff --git a/gertty/view/change_list.py b/gertty/view/change_list.py index efaa639..82a6086 100644 --- a/gertty/view/change_list.py +++ b/gertty/view/change_list.py @@ -69,7 +69,7 @@ class ChangeListView(urwid.WidgetWrap): This Screen =========== Toggle whether only unreviewed or all changes are displayed. - Toggle the reviewed flag for the currently selected change. + Toggle the reviewed flag for the currently selected change. """ def __init__(self, app, project_key): @@ -129,7 +129,7 @@ This Screen self.unreviewed = not self.unreviewed self.refresh() return None - if key=='r': + if key=='v': if not len(self.listbox.body): return None pos = self.listbox.focus_position