ttygroup/gertty
Code Issues Proposed changes

Update patch set 1

Browse Source 
Patch Set 1:

(2 comments)

Patch-set: 1
This commit is contained in:
Gerrit User 19119 2024-02-27 15:54:12 +00:00 committed by Gerrit Code Review
parent 4be15e9d3e
commit 796a6075ff
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
d61a6961faf77bb912fb8983088cdbe209e4442a Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "7f767a5c_1b2f0ced",
"filename": "gertty/mywid.py",
"patchSetId": 1
},
"lineNbr": 53,
"author": {
"id": 19119
},
"writtenOn": "2024-02-27T15:54:12Z",
"side": 1,
"message": "While FIXED `pack` was implemented, `render` still was original and old urwid used only FLOW logic.\nAfter 2.4.2 was implemented distinct FIXED render and pack support in urwid containers (`Columns` and `Pile`).\nThis required strict validation for sizing of element + sizing calculation for widgets instead of historically hardcoded `FLOW`/`FIXED`.",
"revId": "d61a6961faf77bb912fb8983088cdbe209e4442a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8f5fe04e_c2fd7545",
"filename": "requirements.txt",
"patchSetId": 1
},
"lineNbr": 3,
"author": {
"id": 19119
},
"writtenOn": "2024-02-27T15:54:12Z",
"side": 1,
"message": "2.0.0 was in 2018. Everything older is out of deprecation changes window",
"revId": "d61a6961faf77bb912fb8983088cdbe209e4442a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}