Update patch set 1

Patch Set 1:

(9 comments)

Patch-set: 1

1d6b0fd88165938b11be1abd5ffaeeec16278c9e

@@ -0,0 +1,157 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "9ad9bd40_65822202",
+        "filename": "README.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 13,
+      "author": {
+        "id": 1297
+      },
+      "writtenOn": "2014-04-30T00:32:01Z",
+      "side": 1,
+      "message": "Very cool.",
+      "revId": "1d6b0fd88165938b11be1abd5ffaeeec16278c9e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9ad9bd40_e5755233",
+        "filename": "README.rst",
+        "patchSetId": 1
+      },
+      "lineNbr": 33,
+      "author": {
+        "id": 1297
+      },
+      "writtenOn": "2014-04-30T00:32:01Z",
+      "side": 1,
+      "message": "Eck, can we prompt for this if it doesn\u0027t exist? Passwords in text files scare me.",
+      "revId": "1d6b0fd88165938b11be1abd5ffaeeec16278c9e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9ad9bd40_8503a672",
+        "filename": "gertty/gertty.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 123,
+      "author": {
+        "id": 1297
+      },
+      "writtenOn": "2014-04-30T00:32:01Z",
+      "side": 1,
+      "message": "Should this be a daemon thread?",
+      "revId": "1d6b0fd88165938b11be1abd5ffaeeec16278c9e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9ad9bd40_05d8761c",
+        "filename": "gertty/gertty.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 165,
+      "author": {
+        "id": 1297
+      },
+      "writtenOn": "2014-04-30T00:32:01Z",
+      "side": 1,
+      "message": "To make it exit cleanly I think u need?\n\nif key in (\u0027q\u0027, \u0027Q\u0027):\n  raise urwid.ExitMainLoop()",
+      "revId": "1d6b0fd88165938b11be1abd5ffaeeec16278c9e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9ad9bd40_c585aeae",
+        "filename": "gertty/sync.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 373,
+      "author": {
+        "id": 1297
+      },
+      "writtenOn": "2014-04-30T00:32:01Z",
+      "side": 1,
+      "message": "Daemon thread?",
+      "revId": "1d6b0fd88165938b11be1abd5ffaeeec16278c9e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9ad9bd40_c5acce38",
+        "filename": "gertty/view/diff.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 44,
+      "author": {
+        "id": 1297
+      },
+      "writtenOn": "2014-04-30T00:32:01Z",
+      "side": 1,
+      "message": "urwid has alot of constants setup for this\n\nurwid.WEIGHT (and similar, for \u0027pack\u0027...) what do u thnk about using them where possible?",
+      "revId": "1d6b0fd88165938b11be1abd5ffaeeec16278c9e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9ad9bd40_4536fe04",
+        "filename": "gertty/view/project_list.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 58,
+      "author": {
+        "id": 1297
+      },
+      "writtenOn": "2014-04-30T00:32:01Z",
+      "side": 1,
+      "message": "Interesting, I always wondered if this is how widgets should be made (with a widget wrap, haha).",
+      "revId": "1d6b0fd88165938b11be1abd5ffaeeec16278c9e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9ad9bd40_25181a84",
+        "filename": "gertty/view/project_list.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 69,
+      "author": {
+        "id": 1297
+      },
+      "writtenOn": "2014-04-30T00:32:01Z",
+      "side": 1,
+      "message": "Does using a list box vs just an array here matter?\n\nIsn\u0027t the urwid.Pile the thing that actually gets displayed (and this listbox is just for holding rows?)",
+      "revId": "1d6b0fd88165938b11be1abd5ffaeeec16278c9e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9ad9bd40_c55a0e50",
+        "filename": "gertty/view/project_list.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 111,
+      "author": {
+        "id": 1297
+      },
+      "writtenOn": "2014-04-30T00:32:01Z",
+      "side": 1,
+      "message": "I\u0027ve always done.\n\nm_key \u003d self._command_map[key]\n\nCommand map seems to be a translation that might be useful for u.\n\nhttps://github.com/wardi/urwid/blob/master/urwid/command_map.py\n\nThat way u aren\u0027t dependent on keys by exact name.",
+      "revId": "1d6b0fd88165938b11be1abd5ffaeeec16278c9e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}