Browse Source

Don't lose sync requests that get bad responses

Gerrit servers under some configurations will return a result that
doesn't fail in checkResponse but isn't JSON. When that happens the
action being synced is discarded and lost.

This has been the case for nearly 4 years as far as I can tell.

Change-Id: I9f4c36cf50acefab4806e7617226c979465d384d
tags/1.6.0
Robert Collins 1 year ago
parent
commit
c72df1cde8
1 changed files with 1 additions and 0 deletions
  1. 1
    0
      gertty/sync.py

+ 1
- 0
gertty/sync.py View File

@@ -1496,6 +1496,7 @@ class Sync(object):
1496 1496
             except Exception:
1497 1497
                 self.log.exception("Unable to parse result %s from post to %s" %
1498 1498
                                    (r.text, url))
1499
+                raise
1499 1500
         return ret
1500 1501
 
1501 1502
     def put(self, path, data):

Loading…
Cancel
Save